From da58751ca2490d5de3a0f7753fd7078c4285c2bc Mon Sep 17 00:00:00 2001 From: Richard Genoud Date: Thu, 28 Mar 2013 12:55:46 +0100 Subject: [PATCH] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked And remove superfluous brackets. Signed-off-by: Richard Genoud Reviewed-by: Stephen Warren Signed-off-by: Linus Walleij --- drivers/pinctrl/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index bcec05b5c67..986d0e02761 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -956,9 +956,8 @@ static int pinctrl_select_state_locked(struct pinctrl *p, break; } - if (ret < 0) { + if (ret < 0) goto unapply_new_state; - } } p->state = state; @@ -966,7 +965,7 @@ static int pinctrl_select_state_locked(struct pinctrl *p, return 0; unapply_new_state: - pr_info("Error applying setting, reverse things back\n"); + dev_err(p->dev, "Error applying setting, reverse things back\n"); /* * If the loop stopped on the 1st entry, nothing has been enabled, -- 2.46.0