From 5cc19b7c5e71bdd1214813c6d65a1dd5b37807ac Mon Sep 17 00:00:00 2001 From: Nishanth Menon Date: Mon, 15 Sep 2014 14:31:22 -0700 Subject: [PATCH] Input: palmas-pwrbutton - use IRQF_ONESHOT make C=2 CHECK="scripts/coccicheck" MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o Reports: drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Palmas power button just needs threaded IRQ handler since I2C operations are involved and there is nothing in non-threaded primary handler we could do. So mark the request with ONESHOT as it should have been done in these cases. Fixes: adff5962fdd2 ("Input: introduce palmas-pwrbutton") Reported-by: kbuild test robot Signed-off-by: Nishanth Menon Signed-off-by: Dmitry Torokhov --- drivers/input/misc/palmas-pwrbutton.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/misc/palmas-pwrbutton.c b/drivers/input/misc/palmas-pwrbutton.c index 3f902110c29..766f594b45e 100644 --- a/drivers/input/misc/palmas-pwrbutton.c +++ b/drivers/input/misc/palmas-pwrbutton.c @@ -211,7 +211,9 @@ static int palmas_pwron_probe(struct platform_device *pdev) pwron->irq = platform_get_irq(pdev, 0); error = request_threaded_irq(pwron->irq, NULL, pwron_irq, - IRQF_TRIGGER_HIGH | IRQF_TRIGGER_LOW, + IRQF_TRIGGER_HIGH | + IRQF_TRIGGER_LOW | + IRQF_ONESHOT, dev_name(dev), pwron); if (error) { dev_err(dev, "Can't get IRQ for pwron: %d\n", error); -- 2.46.0