[COMPLIB] This patch removes a useless comment. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1378 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[MTHCA] This patch cleans up the atomic_set function in the HCA drivers. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1377 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Cleanup ND reject IOCTL handling.
This patch removes a local variable, and changes the reject reason from IB_REJ_INSUF_QP to IB_REJ_USER_DEFINED. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1376 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[OPENMS] This patch removes XXX_PTR64 and TO_ULONG_PTR from OpenSM. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1375 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
The al_cep_drep API currently takes the ib_cm_drep_t structure. This structure is passed in the IOCTL. It has en embedded pointer that isn't used since the private data is copied into the IOCTL structure.
This patch removes the ib_cm_drep_t structure from the IOCTL structure, and passes the private data buffer and length in explicitly.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1374 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[TOOLS] This patch cleans up the includes for the HCA co-installer and corrects the version information to correctly identify the DLL as such (rather than as an executable). Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1373 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
The listen error callback is the vestigial tail of IBAL... At some point in the distant past, it served a function, though a dubious one at best given the implementation of the listen error callbacks in client code that all effectively generate some output but really ignore the event.
This patch eliminates the listen error callback, its associated callback record, and all the no-op handlers in the various clients.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1363 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Driver verifier caught this one. If an IRP is completed via IoCompletRequest the IRP dispatch routine needs to return the same status as the IRP's completion status. There's no reason to use the CL_COMPLETED value here anyway (and it should probably be eliminated to prevent exactly this type of issue.) Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1360 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
This patch fixes a bug in the ND proxy where an IOCTL handler would return STATUS_PENDING without marking the IRP pending. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1359 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
This patch adds a missing call to destroy a QP's associated CEP if a ND-related CM REQ times out or fails for any reason. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1358 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch removes ATS queries from the ND proxy, with the anticipation that all address translation will be done by the caller (via the IBAT library). Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1357 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
In my previous patch "Fix race reading/setting connection ID" I incorrectly stated that the patch changed the semantics of creation/destruction of the CEPs by providing the destroy callback at CEP creation time. It didn't, but this patch does.
Note that it also backs out the "Cleanup CEPs after child objects have been destroyed" changes, as those actually introduced the following issue:
UM listen CEPs are not tracked in AL's handle table, but can queue MADs which take a reference on the AL instance. AL's destroying callback must cleanup the CEPs to free the MADs in order for the ref count to reach zero.
The root problem, and the iterations of the fix that are apparent in the patch sequence has to do with race conditions cleaning up QPs while CM messages are being received and processed. First there was the issue of the CID stored in the QP having two reserved states and races checking/assigning this value. This was fixed (successfully) by pushing checks into the CEP manager, protected by the CEP manager's spinlock. Next was the issue that a reference on the QP is taken when the CEP is bound to a QP, but if AL was destroyed the CEP cleanup in AL would blow away the CEPs before the QPs were done being destroyed. This would leak a reference count on the QP since the CEP was destroyed without a destroy callback. The change that added a cleanup callback to AL was the first (failed) attempt to fix this (for the reasons listed above). This patch is the successful attempt to fix this, as it sets the destroy callback at creation time. No matter what path destroys the CEP, if a destroy callback was taken (because some object has a reference for the CEP), the destroy callback will always be invoked.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1356 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch fixes ND CM IOCTL handling to work properly at scale. There were several race conditions in the old code. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1355 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[SRP] added INX -> INF file version stamping.
INF file created in ..\..\..\bin\kernel\xxx\
.inf file version now matches .sys file version.
added makefile.inc
ib_srp.inf renamed to ib_srp.inx per MS/WDK convention.
[IPOIB] added INX -> INF file version stamping.
INF file created in ..\..\..\bin\kernel\xxx
.inf file version now matches .sys file version.
added makefile.inc
netipoib.inf renamed to netipoib.inx per MS/WDK convention.
[QLGCVNIC] added INX -> INF file stamping. INF file created in ..\..\..\bin\kernel\xxx
.inf file version now matches .sys file version.
added file makefile.inc
netvnic.inf renamed to netvnic.inx per MS/WDK convention.
[WSD] This patch removes the dependency of WSD on DAPL ATS, and reduces connection establishment SA queries from 2 (ATS query + PR query) to 1 (PR query). Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1332 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[CORE, TESTS] This patch adds a library and test utility that performs IP to IB address translation without going to the SA for DAPL ATS service records.
It's a sequence of operations between the IP helper library and IPoIB.
1. Get the local IPoIB port's IB address information (GID).
2. Lookup the destination MAC address via the IP Helper functions, send ARP if needed 3. Ask IPoIB for the destination IB address information given the destination Ethernet MAC.
As input, the IBAT library takes two IP addresses (v4 or v6). As output, it returns two GIDs (as IN6_ADDRs), as well as the pkey.
There's a test program, wherebu, that will exercise the IBAT library.
Note that there is special code for Windows Vista/Server 2008 to take advantage of newer functionality in the IP Helper library. Without this lookups get quite slow as you increase the number of nodes. On our 256 node cluster the Windows Server 2008 code path performed an order of magnitude better than the Windows Server 2003 code path.
There will be a follow up patch that moves WSD over to using this library.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1331 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch fixes IBAL object destruction. It does the following:
1. Removes forcing synchronous destruction for user-mode exported objects. This isn't needed, and slows down cleanup of the object hierarchy.
2. Clears the user-mode exported handle from the handle table before invoking the 'destroying' callback of an object, so that all further reference on the object will fail. Currently, an IOCTL could take a reference on an object after the 'destroying' callback has returned.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1329 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] IBAL currently blows away all CEPs from its 'destroying' callback. This patch moves this so that any left over CEPs are cleaned up in the 'cleanup' callback, so that objects that 'own' a CEP have a chance to clean themselves up first. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1328 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch renames 'que' to 'queue'. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1327 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] IBAL has two reserved CID values that it stores in the QPs - AL_INVALID_CID, meaning that there is no CEP associated with the QP but that one can be associated, and AL_RESERVED_CID, which means no CEP is associated, and none should be because the QP is being destroyed.
The code uses atomic operations to check for/set AL_INVALID_CID or AL_RESERVED_CID. Since there are two possible 'special' values, atomics can't be used reliably.
There has been a report of this related to SRP and BSODs.
Additionally, the code would provide the destroy callback when destroying the CEP. However, the CEP can be destroyed through different paths, and it's important to make sure the destroy callback is invoked always so that reference counts can be properly released.
This patch pushes all assignments and checks for special values into the CEP manager, protected by the CEP manager's lock that it holds when performing the CEP lookup. It also changes the semantics of creation/destruction of the CEPs to provide the destroy callback when the CEP is created or bound to an object (the binding path is for the passive side of a connection).
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1326 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] The current connection establishment code will return STATUS_HOST_UNREACHABLE when an SA operation times out. This patch returns STATUS_TIMEOUT if the SA query timed out, which tends to happen in larger clusters quite often. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1325 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Use the CM protocol to exchange initiator depth and responder resources. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1324 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] The current ndi_dreq_cm function destroys the CEP after the QP is moved to the error state. The CEP should be destroyed first to send the DREQ before changing the QP state. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1323 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] The CEP manager currently keeps a separate field to store the initiator depth requested in a REQ. When the user sends the REP, the CEP stored the responder resources as the minimum of the requested depth or the CA's capabilities.
This change eliminates the separate field, and uses the responder resources to store the received REQ's initiator depth. This simplifies the code a bit.
Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1322 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Convert ib_api_status_t to NTSTATUS for al_cep_get_pdata to make the IRP handling simpler. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1320 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Add code to allow user-mode code to register memory via the existing IBAL IOCTLs, and if that succeeds, issue a no-op IOCTL that completes the user's overlapped request to their IOCP (or whatever mechanism they are using - the I/O manager will take care of it). Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1319 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch changes when the private data is stored to when the CM MAD is received and processed. This makes the code more consistent and simpler. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1318 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch adds a missing reference taken on a QP when delaying the QP modification for a received DREQ. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1317 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch cancels all outstanding UAL_CEP_GET_REQ_CID IRPs queued in a CEP when the CEP is destroyed. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1316 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] Cleanup dead code in IBAL. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1315 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[IBAL] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBAL. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1314 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from interface files. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1313 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[TESTS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from \tests. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1312 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
[HW] improved memory allocation mechanism. (posix_memalign was implemented by VirtualAlloc, which, as it turned out, allocates 64KB instead of 4KB) [MLNX: 2601]
ftillier [Mon, 30 Jun 2008 17:15:54 +0000 (17:15 +0000)]
Make build scripts easier to use:
- bldwo.bat now accepts multiple build parameters, so you can separate them.
For example, bldwo chk x86 2008 -Ccwg is the same as bldwo chk x86 2008 -C -c -w -g.
- eliminate the need for the WINOF_PATH environment variable so it can be run
from any directory.
- bldwoall.bat now passes all extra parameters to bldwo.bat
- bldwoall.bat now picks up bldwo.bat from the same directory, rather than
the directory from which it was launched.
leonidk [Sun, 29 Jun 2008 17:53:30 +0000 (17:53 +0000)]
[IOU] This patch removes XXX_PTR64 and TO_ULONG_PTR macro usage in the IOU bus driver. It's a kernel driver and doesn't need any padding as it will always have the same pointer size as other kernel drivers. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1308 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
leonidk [Sun, 29 Jun 2008 16:45:16 +0000 (16:45 +0000)]
[IBBUS] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from IBBus. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1307 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
leonidk [Sun, 29 Jun 2008 16:21:53 +0000 (16:21 +0000)]
[SRP] This patch removes XXX_PTR64 and TO_ULONG_PTR macro use from SRP. Signed-off-by: Fab Tillier <ftillier@microsoft.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@1306 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86
stansmith [Sat, 21 Jun 2008 00:27:03 +0000 (00:27 +0000)]
[Core] fixed errant Default Data length when reading registry entry 'PartitionKey' and the key did not exist. Showed up as a BSOD crash when loading ibbus.sys on Server 2003 x86.
stansmith [Wed, 18 Jun 2008 21:54:54 +0000 (21:54 +0000)]
[WinOF] added common exit path with time stamp info (start & end times); curently takes about 15 minutes to compile, sign drivers and build installers on a 4P platform.
projects / ~shefty / rdma-win.git / log