]>
git.openfabrics.org - ~shefty/rdma-dev.git/log
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:28:55 +0000 (11:28 -0700)]
Staging: hv: remove function pointer typedefs from StorVscApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:24:48 +0000 (11:24 -0700)]
Staging: hv: remove function pointer typedefs from NetVscApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:18:10 +0000 (11:18 -0700)]
Staging: hv: remove function pointer typedefs from VmbusApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 17:35:56 +0000 (10:35 -0700)]
Staging: hv: rename struct NETVSC_DEVICE
The Linux kernel doesn't have all caps structures, we don't like to
shout at our programmers, it makes them grumpy. Instead, we like to
sooth them with small, rounded letters, which puts them in a nice,
compliant mood, and makes them more productive and happier, allowing
them more fufilling lives overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 17:33:05 +0000 (10:33 -0700)]
Staging: hv: coding style cleanup for NetVsc.c
Still a lot of long lines, but that's nothing I can fix up at this time
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 16:17:52 +0000 (09:17 -0700)]
Staging: hv: coding style cleanup for RndisFilter.c
It's much better now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 15:37:47 +0000 (08:37 -0700)]
Staging: hv: coding style cleanup for storvsc_drv.c
Where's the hazard pay for cleaning up this mess...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 14:11:14 +0000 (07:11 -0700)]
Staging: hv: coding style cleanups for vmbus_drv.c
Almost clean.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 03:12:58 +0000 (20:12 -0700)]
Staging: hv: warn the world of a bug in the release function
All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all. Stick a big fat
WARN_ON(1); in there to get people's attention.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 00:24:57 +0000 (17:24 -0700)]
Staging: hv: coding style cleanup for Channel.c
All clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 23:34:56 +0000 (16:34 -0700)]
Staging: hv: coding style fixes for blkvsc_drv.c
There are still some very long lines, someone needs to unwind the
logic there to resolve that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 05:31:22 +0000 (22:31 -0700)]
Staging: hv: reorg StorVsc.c
This gets rid of all of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 05:25:48 +0000 (22:25 -0700)]
Staging: hv: coding style cleanups for StorVsc.c
Some one owes me a lot of beer, or a nice bottle of rum for
all of this crud cleanup...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:56:16 +0000 (21:56 -0700)]
Staging: hv: TODO: add some more items
Add List.h and RingBuffer.h removal items.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:51:50 +0000 (21:51 -0700)]
Staging: hv: reorg ChannelMgmt a bit
This gets rid of the unneeded typedef and the forward declarations,
saving a bit of code file size.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:47:21 +0000 (21:47 -0700)]
Staging: hv: coding style cleanups for ChannelMgmt.c
There are still some too-long lines here, hopefully they will get
resolved later.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:11:12 +0000 (21:11 -0700)]
Staging: hv: reorganize netvsc_drv.c
Saves space by getting rid of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:09:45 +0000 (21:09 -0700)]
Staging: hv: coding style cleanups for netvsc_drv.c
There are still some horrible long lines in here, which some simple
code reworking will make smaller and easier to understand.
Also note the FIXME in struct netvsc_driver_context...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 03:23:33 +0000 (20:23 -0700)]
Staging: hv: fix coding style issues in Hv.c
Lots of cleanups.
Note, the use of volatile still needs to be resolved, and
possibly the #ifdef could be done a bit "better".
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 00:37:58 +0000 (17:37 -0700)]
Staging: hv: code reduction from Vmbus.c
Reorder some functions to get rid of all of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 00:37:18 +0000 (17:37 -0700)]
Staging: hv: coding style cleanups on Vmbus.c
It's now much nicer and cleaner.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Mon, 31 Aug 2009 18:40:14 +0000 (11:40 -0700)]
Staging: hv: coding style cleanups for Connection.c
Everything is clean except for some very long lines that
need a bit more code rework to resolve. That will have to be done by
someone that can test the code.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:48 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from StorVsc.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:27 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from RndisFilter.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:11 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from ChannelMgmt.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:25:39 +0000 (16:25 -0700)]
Staging: hv: coding style cleanups of ChannelInterface.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:25:21 +0000 (16:25 -0700)]
Staging: hv: coding style cleanups of BlkVsc.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:48 +0000 (16:24 -0700)]
Staging: hv: move VmbusPacketFormat.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:34 +0000 (16:24 -0700)]
Staging: hv: move VmbusChannelInterface.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:16 +0000 (16:24 -0700)]
Staging: hv: move VmbusApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:49 +0000 (16:23 -0700)]
Staging: hv: move StorVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:17 +0000 (16:23 -0700)]
Staging: hv: move NetVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:59 +0000 (16:22 -0700)]
Staging: hv: move logging.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:45 +0000 (16:22 -0700)]
Staging: hv: move List.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:33 +0000 (16:22 -0700)]
Staging: hv: remove ChannelMessages.h
It's only ever used within the ChannelMgmt.h file, so pull it
into there.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:21:33 +0000 (16:21 -0700)]
Staging: hv: move nvspprotocol.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:53 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in nvspprotocol.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:34 +0000 (16:20 -0700)]
Staging: hv: fix coding style issues in nvspprotocol.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:07 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in StorVscApi.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:19:17 +0000 (16:19 -0700)]
Staging: hv: fix coding style issues in StorVscApi.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:02:36 +0000 (16:02 -0700)]
Staging: hv: remove typedefs from VmbusPacketFormat.h
All spiffied up now, shines like a brass button on the bump of a barge's
bilge.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:01:23 +0000 (16:01 -0700)]
Staging: hv: fix coding style issues in VmbusPacketFormat.h
Heh, volatiles, like that was a good idea... Turns out they were not
even used, wierd stuff.
All clean except for the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:00:24 +0000 (16:00 -0700)]
Staging: hv: fix typedefs in vstorage.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:59:39 +0000 (15:59 -0700)]
Staging: hv: fix remaining style issue in ChannelInterface.h
It snuck in with the other typedef cleanups, sorry about that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:52 +0000 (15:58 -0700)]
Staging: hv: move vstorage.h to hv dir
Move it out of the include subdir, it doesn't need to
be there.
No code was changed in the move.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:15 +0000 (15:58 -0700)]
Staging: hv: fix up typedefs in NetVscApi.h
It's now all clean from a coding style standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:57:15 +0000 (15:57 -0700)]
Staging: hv: fix up coding style issues in NetVscApi.h
Everything but the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:55:48 +0000 (15:55 -0700)]
Staging: hv: fix up some coding style issues in logging.h
It's now clean.
Well, from a coding style guide, not from a logic standpoint, the whole
file needs to be tossed overboard and cheered on as the sharks tear it
to individual bits.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:16:04 +0000 (15:16 -0700)]
Staging: hv: typedef removal for ChannelMessages.h
ChannelMessages.h is now coding style clean.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:14:51 +0000 (15:14 -0700)]
Staging: hv: codingsyle cleanups for ChannelMessages.h
Everything but the typedefs are taken care of.
Also a number of unused defines were removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:17:36 +0000 (12:17 -0700)]
Staging: hv: typedef removal for VmbusApi.h
The function pointers still have ugly names, but the structures
are now cleaned up.
Note, a comment was added where the driver structure is pointing
at a problem that needs to be fixed up later in the code.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:16:33 +0000 (12:16 -0700)]
Staging: hv: coding style cleanups for VmbusApi.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: typedef removal from VmbusChannelInterface.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: coding style cleanups for VmbusChannelInterface.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:17 +0000 (12:15 -0700)]
Staging: hv: move HvStatus.h into hv_api.h
It doesn't need to be a standalone file anymore.
No code changed, only moving things around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:14:11 +0000 (12:14 -0700)]
Staging: hv: coding style cleanups for HvStatus.h
Ugh, what a mess, it's all better now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:13:27 +0000 (12:13 -0700)]
Staging: hv: create hv_api.h
Merge the different include/Hv*Api.h files together into
hv_api.h as they really don't justify separate files.
No code was changed here, only moving stuff around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:12:31 +0000 (12:12 -0700)]
Staging: hv: remove volatile usage from HvSynicApi.h
It's pretty pointless as no one is using this structure, but even so
the use of volatile is so wrong here it's sad...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:11:26 +0000 (12:11 -0700)]
Staging: hv: typdef fixes for HvSynicApi.h
Still some volatile mis-usages left to fix.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:10:52 +0000 (12:10 -0700)]
Staging: hv: coding style cleanups for HvSynicApi.h
Don't fix the typedef issues, that will come next.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:09:34 +0000 (12:09 -0700)]
Staging: hv: coding style cleanups for HvPtApi.h
Fix up the typedefs in there as well.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:26:24 +0000 (16:26 -0700)]
Staging: hv: rndis.h: typedef removal, part 2
This removes the rest of the typedefs in rndis.h
The file is now checkpatch.pl clean.
Note, there are a lot of structures in this file that are not used
anywhere. I don't know if we want to remove them, but I guess they
don't take up any space so it's a nice documentation trail.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:26:24 +0000 (16:26 -0700)]
Staging: hv: rndis.h: typedef removal, part 1
This removes about half of the typedefs in rndis.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:25:51 +0000 (16:25 -0700)]
Staging: hv: rndis.h: codingstyle fixes
This fixes all of the coding style issues in rndis.h with the
exception of the typedefs. That comes next.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:25:13 +0000 (16:25 -0700)]
Staging: hv: rndis.h: remove pointless typedefs
The typedefs for u32 are now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:24:29 +0000 (16:24 -0700)]
Staging: hv: move rndis.h
This moves rndis.h from the include/ subdirectory. It doesn't
belong there.
No code changes happened here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:23:45 +0000 (16:23 -0700)]
Staging: hv: vmbus.h coding style cleanups
Coding style fixes for vmbus.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: move vmbus.h
This moves vmbus.h from the include/ subdirectory. It doesn't
belong there.
No code changes happened here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: coding style cleanup of include/HvVpApi.h
Coding style fixes for include/HvVpApi.h
All of the include/Hv*.h files should be merged eventually...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: coding style cleanup of include/HvHcApi.h
Coding style fixes for include/HvHcApi.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:20:41 +0000 (16:20 -0700)]
Staging: hv: remove include/HvHalApi.h
It isn't needed at all, was only being used for one typedef,
which is now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:20:15 +0000 (16:20 -0700)]
Staging: hv: remove include/HvTypes.h
It isn't needed at all, was only being used for one typedef,
which is now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:19:23 +0000 (16:19 -0700)]
Staging: hv: osd.c: coding style fixes
Codingstyle fixes for osd.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:18:56 +0000 (16:18 -0700)]
Staging: hv: osd.h: fix GUID reference problem
As GUID was a typedef, it hid the fact that we were passing it
a 2 variables in functions. This fixes this up by passing it
as a pointer, as it should be.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:17:03 +0000 (16:17 -0700)]
Staging: hv: osd.h: remove GUID typedef
GUID should not be a typedef. As proof of the problem of typedefs,
look, we are passing 2 of these as a value in functions! Bah...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:16:21 +0000 (16:16 -0700)]
Staging: hv: osd.h: codingstyle cleanups
This fixes up the coding style issues in osd.h, with the exception of
the typedefs, they will be removed later.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:14:47 +0000 (16:14 -0700)]
Staging: hv: move osd.h
This moves osd.h out of the include/ subdirectory.
No code changes are made here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:21:19 +0000 (15:21 -0700)]
Staging: hv: clean up vstorage.h
Lots of coding style cleanups in vstorage.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:21:19 +0000 (15:21 -0700)]
Staging: hv: clean up typedefs in ChannelMgmt.h
This removes the typedefs from ChannelMgmt.h, it's now clean from a
codingstyle.pl standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:20:34 +0000 (15:20 -0700)]
Staging: hv: clean up typedefs in Hv.h
This removes the typedefs from Hv.h, it's now clean from a
codingstyle.pl standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:19:43 +0000 (15:19 -0700)]
Staging: hv: clean up RndisFilter.h
Cleans up coding style issues with RndisFilter.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:18:36 +0000 (15:18 -0700)]
Staging: hv: clean up NetVsc.h
Cleans up coding style issues with NetVsc.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: remove Sources.c
It's a .c file including other .c files, ick.
Remove that mess now that the header files are unwound.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in RingBuffer.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:23:00 +0000 (17:23 -0700)]
Staging: hv: cleanup coding style issues in VmbusPrivate.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in ChannelMgmt.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in ChannelInterface.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:21:51 +0000 (17:21 -0700)]
Staging: hv: cleanup coding style issues in VersionInfo.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:21:31 +0000 (17:21 -0700)]
Staging: hv: cleanup coding style issues in Channel.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:20:55 +0000 (17:20 -0700)]
Staging: hv: cleanup coding style issues in Hv.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:20:02 +0000 (17:20 -0700)]
Staging: hv: remove ReadMsr and WriteMsr functions from Hv.h
They aren't needed as wrappers.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jan Beulich [Mon, 17 Aug 2009 11:54:31 +0000 (05:54 -0600)]
Staging: hv: adjust Hyper-V Kconfig
Hyper-V sub-components' options should all depend on the base option.
The default of these sub-component options is also more reasonably set
to that of the base option (since it makes little sense to enable the
base option without the sub-component ones).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Fri, 7 Aug 2009 18:17:04 +0000 (11:17 -0700)]
Staging: hv: blk dev depends on SCSI
hv block driver uses scsi_*() interfaces so it should depend on SCSI.
ERROR: "scsi_normalize_sense" [drivers/staging/hv/hv_blkvsc.ko] undefined!
ERROR: "scsi_print_sense_hdr" [drivers/staging/hv/hv_blkvsc.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Thu, 30 Jul 2009 15:37:23 +0000 (17:37 +0200)]
Staging: hv: Replace typedef SG_BUFFER_LIST by struct scatterlist
typedef SG_BUFFER_LIST is removed and its uses are replaced by the use of
struct scatterlist.
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:42:27 +0000 (15:42 -0700)]
Staging: hv: remove duplicated osd.o inclusions
Now that we have properly prefixed the osd.c functions, we don't need to
include it in each of the modules. So only build it into the hv_vmbus
module.
Export the symbols that the other hv_ modules need, so that they can
properly find them.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:40:57 +0000 (15:40 -0700)]
Staging: hv: remove timer wrapper functions
Use a real timer (there's only one in the code), no wrapper is needed,
it just increases the complexity for no reason.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:40:18 +0000 (15:40 -0700)]
Staging: hv: osd: add osd_ prefix to global functions
Put a "osd_" prefix on the osd.c functions in order for us to play nicer
in the kernel namespace.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:39:27 +0000 (15:39 -0700)]
Staging: hv: osd: remove physical address wrapper functions
Use the real functions the kernel provides, so that people can see what
is actually going on in the code easier.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:38:00 +0000 (15:38 -0700)]
Staging: hv: remove custom rdmsrl and wrmsrl functions
Use the ones that the kernel provides, they do it correctly.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:37:12 +0000 (15:37 -0700)]
Staging: hv: remove custom cpuid function
Use the one that the kernel provides, it does it correctly.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>