Sean Hefty [Mon, 17 May 2010 21:37:30 +0000 (14:37 -0700)]
librdmacm: define struct ibv_path_record if not defined
librdmacm relies on struct ibv_path_record from libibverbs. However,
to support older versions of libibverbs, define struct ibv_path_record
if it is not already defined.
Sean Hefty [Tue, 11 May 2010 18:15:47 +0000 (11:15 -0700)]
librdmacm: disable AF_IB support
To avoid potential compatability issues, disable AF_IB support
until it has been queued for inclusion upstream. We will re-enable
AF_IB support after releasing version 1.0.12 for OFED 1.5.2, which
will include support for IB ACM.
Sean Hefty [Thu, 6 May 2010 22:51:38 +0000 (15:51 -0700)]
librdmacm: use IB ACM to resolve IB path
Starting with 2.6.33, the kernel supports the ability to
manually specify the path record that a connection should
use. Allow the librdmacm to contact the IB ACM to acquire
path record data, even if rdma_getaddrinfo is not used and
the kernel does not support AF_IB.
Sean Hefty [Thu, 6 May 2010 22:50:57 +0000 (15:50 -0700)]
librdmacm/rdma_server: add new sample server application
Provide a simple server application to demonstrate the minimal
amount of coding needed to accept a connection request from
a client and exchange messages.
Sean Hefty [Thu, 6 May 2010 22:50:54 +0000 (15:50 -0700)]
librdmacm/rdma_client: add new client sample
Provide a very simple client application that shows the
minimal coding needed to establish a connection and exchange
messages with a server. The client makes use of the new
rdma_getaddrinfo and rdma_create_ep calls, plus rdma verbs
abstractions.
Sean Hefty [Thu, 6 May 2010 22:50:50 +0000 (15:50 -0700)]
librdmacm: provide abstracted verb calls
Provide abstractions to the verb calls to simplify the user
interface for more casual verbs consumers. Users still have
access to the full range of verbs functionality by calling
verbs directly.
Sean Hefty [Thu, 6 May 2010 22:50:43 +0000 (15:50 -0700)]
librdmacm: format IB CM private data RDMA CM header
When IB ACM is used, the address and route resolution is
done entirely in user space. Before converting AF_INET or
AF_INET6 addresses to AF_IB, format the connection private
data for IB CM REQ messages.
Sean Hefty [Thu, 6 May 2010 22:49:55 +0000 (15:49 -0700)]
librdmacm: use sockaddr_ib addressing if IB ACM is in use
If IB ACM route resolution succeeds, provide the user with
AF_IB addresses, rather than AF_INET or AF_INET6 addressing.
AF_IB identifies the local and remote devices directly,
eliminating the need to perform address resolution a second
time via rdma_resolve_addr.
AF_IB addresses are returned using sockaddr_ib as part of
rdma_getaddrinfo.
Sean Hefty [Thu, 6 May 2010 22:48:53 +0000 (15:48 -0700)]
librdmacm: add support for IB ACM service
Allow the librdmacm to contact a service via sockets to obtain
address mapping and path record data. The use of the service
is controlled through a build option (with-ib_acm). If the
library fails to contact the service, it falls back to using
the kernel services to resolve address and routing data.
Sean Hefty [Thu, 6 May 2010 22:47:23 +0000 (15:47 -0700)]
librdmacm: specify qp_type when creating id
To support AF_IB / PS_IB, we need to specify the qp type when
creating the rdma_cm_id. The kernel requires this in order
to select the correct type of operation to perform (e.g. SIDR
versus REQ).
Sean Hefty [Thu, 6 May 2010 22:46:37 +0000 (15:46 -0700)]
librdmacm: add rdma_get_request
To simplify passive side operation and better support synchronous
operations, add rdma_get_request(). This function is called on the
listening side to retrieve a connection request event.
Sean Hefty [Thu, 6 May 2010 22:46:32 +0000 (15:46 -0700)]
librdmacm: add rdma_getaddrinfo
Provide a call similar to getaddrinfo for RDMA devices and
connections. rdma_get_addrinfo is modeled after getaddrinfo, with
the following modifications:
A source address is returned as part of the call to allow the
user to allocate the necessary resources for connections.
Optional routing information may be returned to support
Infiniband fabrics. IB routing information includes necessary
path record data.
Sean Hefty [Thu, 6 May 2010 22:45:05 +0000 (15:45 -0700)]
librdmacm: allow user to specify max RDMA resouces
Allow the user to indicate that the library should select the
maximum RDMA read values available should be used when
establishing a connection. The library selects the maximum
based on local hardware limitations and connection request
data.
Sean Hefty [Thu, 6 May 2010 22:44:57 +0000 (15:44 -0700)]
librdmacm: make CQs optional for rdma_create_qp
Allow the user to specify NULL for the send and receive CQs when
creating a QP through rdma_create_qp. The librdmacm will automatically
create CQs for the user, along with completion channel.
Sean Hefty [Thu, 6 May 2010 22:44:52 +0000 (15:44 -0700)]
librdmacm: allow pd parameter to be optional
Allow the user to create a QP using rdma_create_qp without
specifying a PD. If a PD is not given, a default PD will be
used instead. This simplifies the user interface.
Sean Hefty [Thu, 6 May 2010 22:44:16 +0000 (15:44 -0700)]
librdmacm: replace query_route call with separate queries
To support other address families and multiple path records,
replace the query_route call with specific query calls to obtain
only the desired information.
Sean Hefty [Wed, 7 Apr 2010 18:01:52 +0000 (11:01 -0700)]
librdmacm: support querying AF_IB addresses
The current query route command returns path record data and address
information. The latter is restricted to sizeof(sockaddr_in6). In
order to support AF_IB, modify the library to use the new query addr
command, which supports larger address sizes and avoids querying for
path records data when none are available.
Sean Hefty [Wed, 7 Apr 2010 18:01:43 +0000 (11:01 -0700)]
librdmacm: name changes to indicate only IP addresses supported
Several commands to the kernel RDMA CM only support IP addresses
because of limitations in the structure definition. Update
the library to match the name changes in the kernel and indicate
that only IP addresses can be used with the current commands.
Sean Hefty [Fri, 5 Feb 2010 22:25:15 +0000 (14:25 -0800)]
librdmacm: transition QP to RTS before sending reply
In order to handle a race condition where the passive side of
a connection can receive data on a QP before the connection established
event has been received, transition the QP to RTS before sending the reply.
This allows a user to send a response to any received message immediately,
rather than waiting until the connection established event has been
processed.
A similar fix was applied to the kernel rdma_cm a while ago.
Simply duplicate the fix in the user space library.
Or Gerlitz [Mon, 9 Nov 2009 22:46:20 +0000 (14:46 -0800)]
librdmacm/mckey: enforce local binding for unmapped multicast address
Enforce that mckey is bound to a local address when specifying
an unmapped multicast address. Otherwise, mckey crashes when
attempting to use cmd_id->verbs pointer.
Update documentation on using unmapped MGIDs.
Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Jason Gunthorpe [Wed, 21 Oct 2009 15:02:43 +0000 (08:02 -0700)]
librdmacm: returns errors from the library consistently
Remove the return of -errno and always return codes via errno.
As documented in librdmacm, these libraries are already documented
to return -1 to indicate the code is in errno.
Update rping to show correct error reporting methodology.
Also fix errant return of 0 if the read/write syscalls return 0.
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Mon, 19 Oct 2009 14:21:42 +0000 (07:21 -0700)]
librdmacm: fix race initializing library
Multi-threaded code can race with ucma_init(). When ucma_init() is called
it can set cma_dev_cnt before it is done initializing the library. If
a second thread checks cma_dev_cnt and finds it non-zero, then it will
skip the call to ucma_init() and assume that the library is ready for use.
This can lead to an application crash during startup.
Do not set cma_dev_cnt until the end of ucma_init(), after all
initialization has completed. Adjust the error handling code in
ucma_init() accordingly.
Sean Hefty [Wed, 14 Jan 2009 22:31:34 +0000 (14:31 -0800)]
cmatose: avoid missing completions
cmatose uses a single CQ for send and receive completions. It then
counts completions to determine if all sends and receives are done.
It's possible for a receive completion to be polled when the intent
is to count send completions. (See server side polling for sends
done, then receives done. The poll will get up to 8 completions,
which can lead to sends and receives being polled together.)
Fix this by separating the send and receive completions to their
own CQs to avoid any issues knowing what type of receives have been
polled from the CQ.
Or Gerlitz [Wed, 2 Jul 2008 18:53:49 +0000 (11:53 -0700)]
librdmacm: implement address change event
RDMA_CM_EVENT_ADDR_CHANGE event can be used by librdmacm consumers
that wish to have their RDMA sessions always use the same links
(eg <hca/port>) as the IP stack does. In the current code, this
does not happen when bonding is used and fail-over happened,
but the IB link used by an already existing session is operating fine.
The kernel rdma-cm code was enhanced to use netevent notification
for sensing that a change has happened in the IP stack, and deliver
this event for ID that is misaligned that respect with the IP
stack. The user can act on the event or just ignore it
Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Thu, 22 May 2008 14:35:13 +0000 (07:35 -0700)]
librdmacm: fix license text
The license text for references a third software license
that was inadvertently copied in. Update the license to match that used
by openfabrics. This update was based on a request from HP.
Sean Hefty [Wed, 20 Feb 2008 16:53:19 +0000 (08:53 -0800)]
librdmacm: add rdma_migrate_id
This is based on user feedback from Doug Ledford at RedHat:
Events that occur on an rdma_cm_id are reported to userspace through
an event channel. Connection request events are reported
on the event channel associated with the listen. When the
connection is accepted, a new rdma_cm_id is created and automatically
uses the listen event channel. This is suboptimal where the user
only wants listen events on that channel.
Additionally, it may be desirable to have events related to
connection establishment use a different event channel than those
related to already established connections.
Allow the user to migrate an rdma_cm_id between event channels.
Roland Dreier [Mon, 21 Jan 2008 18:21:44 +0000 (10:21 -0800)]
Update %install secion of librdmacm spec file
Change from using the %makeinstall macro to using "make install"
directly. The page <http://fedoraproject.org/wiki/Packaging/Guidelines>
has this to say:
"Fedora's RPM includes a %makeinstall macro but it must NOT be used
when make install DESTDIR=%{buildroot} works. %makeinstall is a
kludge....
It is error-prone and can have unexpected effects....
It can trigger unnecessary and wrong rebuilds....
....it can cause broken *.la files to be installed....
Instead, Fedora packages should use: make DESTDIR=%{buildroot}
install or make DESTDIR=$RPM_BUILD_ROOT install"
The librdmacm package uses automake, which means that the "make
DESTDIR=... install" method works fine, so we should use it.
Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Roland Dreier [Mon, 21 Jan 2008 18:21:41 +0000 (10:21 -0800)]
Updated License: field in librdmacm spec file
Update License: field to match the exact format given in
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
for a package available under a choice of GPL or BSD license.
Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Thu, 3 Jan 2008 23:36:14 +0000 (15:36 -0800)]
librdmacm/cm: override default responder_resources with user value
By default, the responder_resources parameter is set to that received
in a connection request. The passive side may override this value
when accepting the connection. Use the value provided by the passive
side when transitioning the QP to RTR state, rather than the value
given in the connect request. Without this change, the RTR transition
may fail if the passive side supports fewer responder_resources than
that in the request.
Sean Hefty [Tue, 6 Nov 2007 19:07:55 +0000 (11:07 -0800)]
librdmacm/man: fix-up man pages
Fix a couple of errors in the man page documentation and add
infiniband specific text about QP configuration settings. This
is in response to user questions about various settings based
on feedback from Or.
Sean Hefty [Tue, 16 Oct 2007 21:59:21 +0000 (14:59 -0700)]
librdmacm/cma: provide sanity checks for max outstanding rdma ops
Ensure that the responder_resources and initiator_depth values
provided by the user are supported by the local hardware. This
traps errors sooner during connection establishment (when calling
rdma_connect), rather than waiting until the modify QP fails
(after calling rdma_accept).
Sean Hefty [Tue, 16 Oct 2007 16:47:22 +0000 (09:47 -0700)]
librdmacm/man: update man pages to clarify connection request params
Document connection requests parameters in rdma_connect(),
rdma_accept(), and rdma_get_cm_event(), specifically regarding
initiator_depth and responder_resources.
The private_data_len on the receive side is the size of the data
buffer, and not the size of the private data sent by the remote side.
For IB, the size of the sent data is not known, so private_data_len
is the size of the private data field carried in the CM message.
Dotan Barak [Tue, 14 Aug 2007 16:04:05 +0000 (09:04 -0700)]
librdmacm: Fix memory leak reported by valgrind
Fix memory leak reported by valgrind:
==6239== 16 bytes in 1 blocks are definitely lost in loss record 2 of 10
==6239== at 0x4A04CBF: calloc (vg_replace_malloc.c:279)
==6239== by 0x4E386C4: ibv_get_device_list@@IBVERBS_1.1 (device.c:65)
==6239== by 0x4C2D868: ucma_init (cma.c:221)
==6239== by 0x4C2F831: rdma_create_event_channel (cma.c:299)
==6239== by 0x4018A5: main (cmatose.c:650)
Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
projects / ~shefty / librdmacm.git / log