Roland Dreier [Mon, 21 Jan 2008 18:21:44 +0000 (10:21 -0800)]
Update %install secion of librdmacm spec file
Change from using the %makeinstall macro to using "make install"
directly. The page <http://fedoraproject.org/wiki/Packaging/Guidelines>
has this to say:
"Fedora's RPM includes a %makeinstall macro but it must NOT be used
when make install DESTDIR=%{buildroot} works. %makeinstall is a
kludge....
It is error-prone and can have unexpected effects....
It can trigger unnecessary and wrong rebuilds....
....it can cause broken *.la files to be installed....
Instead, Fedora packages should use: make DESTDIR=%{buildroot}
install or make DESTDIR=$RPM_BUILD_ROOT install"
The librdmacm package uses automake, which means that the "make
DESTDIR=... install" method works fine, so we should use it.
Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Roland Dreier [Mon, 21 Jan 2008 18:21:41 +0000 (10:21 -0800)]
Updated License: field in librdmacm spec file
Update License: field to match the exact format given in
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
for a package available under a choice of GPL or BSD license.
Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Thu, 3 Jan 2008 23:36:14 +0000 (15:36 -0800)]
librdmacm/cm: override default responder_resources with user value
By default, the responder_resources parameter is set to that received
in a connection request. The passive side may override this value
when accepting the connection. Use the value provided by the passive
side when transitioning the QP to RTR state, rather than the value
given in the connect request. Without this change, the RTR transition
may fail if the passive side supports fewer responder_resources than
that in the request.
Sean Hefty [Tue, 6 Nov 2007 19:07:55 +0000 (11:07 -0800)]
librdmacm/man: fix-up man pages
Fix a couple of errors in the man page documentation and add
infiniband specific text about QP configuration settings. This
is in response to user questions about various settings based
on feedback from Or.
Sean Hefty [Tue, 16 Oct 2007 21:59:21 +0000 (14:59 -0700)]
librdmacm/cma: provide sanity checks for max outstanding rdma ops
Ensure that the responder_resources and initiator_depth values
provided by the user are supported by the local hardware. This
traps errors sooner during connection establishment (when calling
rdma_connect), rather than waiting until the modify QP fails
(after calling rdma_accept).
Sean Hefty [Tue, 16 Oct 2007 16:47:22 +0000 (09:47 -0700)]
librdmacm/man: update man pages to clarify connection request params
Document connection requests parameters in rdma_connect(),
rdma_accept(), and rdma_get_cm_event(), specifically regarding
initiator_depth and responder_resources.
The private_data_len on the receive side is the size of the data
buffer, and not the size of the private data sent by the remote side.
For IB, the size of the sent data is not known, so private_data_len
is the size of the private data field carried in the CM message.
Dotan Barak [Tue, 14 Aug 2007 16:04:05 +0000 (09:04 -0700)]
librdmacm: Fix memory leak reported by valgrind
Fix memory leak reported by valgrind:
==6239== 16 bytes in 1 blocks are definitely lost in loss record 2 of 10
==6239== at 0x4A04CBF: calloc (vg_replace_malloc.c:279)
==6239== by 0x4E386C4: ibv_get_device_list@@IBVERBS_1.1 (device.c:65)
==6239== by 0x4C2D868: ucma_init (cma.c:221)
==6239== by 0x4C2F831: rdma_create_event_channel (cma.c:299)
==6239== by 0x4018A5: main (cmatose.c:650)
Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Fri, 20 Apr 2007 22:16:07 +0000 (15:16 -0700)]
librdmacm: update datagram tests to abort if msg size > MTU
If the user specifies a message size for mckey or udaddy tests that's
larger than the active MTU of the bound port, the sends will fail.
Detect this condition and abort the test if the message size is >
the active MTU of the port.
Sean Hefty [Fri, 6 Apr 2007 17:14:02 +0000 (10:14 -0700)]
RDMA/cma: fix 32-bit user / 64-bit kernel mismatch issue
A 64-bit kernel will pad the size of the event structure to a
multiple of 8-bytes. When using a 32-bit kernel, the structure is left
aligned to a 4-byte boundary. This results in the userspace event structure
being too small because of the padding. Fix this by increasing the padding
at the end of the userspace event structure.
Sean Hefty [Wed, 31 Jan 2007 01:37:12 +0000 (17:37 -0800)]
Update mckey test program to join specific multicast groups.
Add options to mckey to allow a user to specify a given multicast group.
This allows the user to join a group using IP address 0, get back the
actual group MGID that was created for the user, and join that group from
a separate copy of mckey.
Sean Hefty [Fri, 26 Jan 2007 18:21:17 +0000 (10:21 -0800)]
Allow unicast traffic over IPOIB port space.
Adjust the RMDA_PS_IPOIB to allow unicast traffic. This requires
changing how QPs are initialized in order to get the correct qkey
to use. We need to call into the kernel to get the initial QP
attributes.
Update the udaddy unicast test program to test this capability.
Sean Hefty [Wed, 24 Jan 2007 00:11:45 +0000 (16:11 -0800)]
Add support to join IPOIB multicast groups
Add to the librdmacm an IPOIB port space that allows interoperability with
IPOIB multicast traffic. Use of the RDMA_PS_IPOIB is limited to multicast
join/leave.
Rename the RDMA_UD_QKEY to RDMA_UDP_QKEY to signify that the qkey is only
used with the RDMA_PS_IPOIB port space. Update mckey test program based on
patch from Or Gerlitz.
Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Mon, 8 Jan 2007 22:27:43 +0000 (14:27 -0800)]
librdmacm: return 0 if rdma_leave_multicast is successful.
Return 0 if leave multicast succeeds, rather than the size of the write.
Update mckey test program to call rdma_leave_multicast to verify its
operation.
Steve Wise [Fri, 15 Dec 2006 22:56:06 +0000 (16:56 -0600)]
librdmacm Pass back the status or errno in RDMA CM events.
The librdmacm code isn't passing back the errno in all events.
For example, if a connection request times out the kernel CMA will pass
up event RDMA_CM_EVENT_UNREACHABLE with the status set to -ETIMEDOUT.
This errno isn't currently passed back to the librdmacm user in the event.
Signed-off-by: Steve Wise <swise@opengridcomputing.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Tue, 5 Dec 2006 03:17:44 +0000 (19:17 -0800)]
Update librdmacm to support ABI version 3
rdma_ucm ABI 3 adds support for reporting connection information with
connect events and UDP port space support. Update the librdmacm to
take advantage of these features, and update test programs as well.
Sean Hefty [Tue, 5 Sep 2006 19:32:38 +0000 (19:32 +0000)]
r9272: Update documentation for rdma_destroy_id to call out that it will cancel
any oustanding asynchronous operation on the id. Suggested clarification
by Or.
Sean Hefty [Tue, 29 Aug 2006 22:03:47 +0000 (22:03 +0000)]
r9183: Need to poll both send and receive completions from the CQ on the passive side
of the connection. Without polling the sends first, we exit before receiving
all replies.
Sean Hefty [Thu, 24 Aug 2006 17:36:24 +0000 (17:36 +0000)]
r9105: Older versions of Linux do not have the misc device. Backport patches create
the RDMA CM abi_version file under /sys/class/infiniband_ucma, so we'll auto-
matically look there for the abi_version if we don't find it in its normal
location.
Steve Wise [Fri, 18 Aug 2006 21:06:41 +0000 (21:06 +0000)]
r9008: Set the QKEY to a common global value for all UD QPs and multicast groups
created by the RDMA CM. This lets a UD QP be used for datagram communication,
as well as multicast group communication over any number of groups.
Signed-off-by: Steve Wise <swise@opengridcomputer.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Mon, 24 Jul 2006 17:29:56 +0000 (17:29 +0000)]
r8647: Re-instate fix from svn 7079, which was removed in svn 7497.
On kernels 2.6.9 an older, class/misc does not exist. To support kernel
backports, if we are unable to locate rdma_cm/abi_version, assume the
latest version. If we're wrong, we'll fail later in the code calling into
the ABI.
Sean Hefty [Fri, 14 Jul 2006 16:19:16 +0000 (16:19 +0000)]
r8523: Add calls to the RDMA CM to return its list of RDMA devices. The calls are
similar to ibv_get_device_list() / ibv_free_device_list().
Without this patch, RDMA device contexts are handed to the user only after
they create an rdma_cm_id and bind it to a local device. By exposing the
device list to the user, it makes it easier for the user to allocate device
specific resources (such as PDs, CQs, etc.) that are shared among multiple
rdma_cm_id's.
Sean Hefty [Fri, 16 Jun 2006 19:31:02 +0000 (19:31 +0000)]
r8084: Add support to the userspace RDMA CM library for joining and leaving multicast
groups based on IP addressing. Add a goofy test program for this.
Boyd Faulkner [Tue, 13 Jun 2006 17:26:11 +0000 (17:26 +0000)]
r7966: This patch resolves a race condition between the receipt of
a connection established event and a receive completion from
the client. The server no longer goes to connected state but
merely waits for the READ_ADV state to begin its looping. This
keeps the server from going back to CONNECTED from the later
states if the connection established event comes in after the
receive completion (i.e. the loop starts).
Roland Dreier [Thu, 25 May 2006 16:38:11 +0000 (16:38 +0000)]
r7497: Development versions of libibverbs don't include libsysfs headers or
link with libsysfs implicitly any more. So libibcm and librdmacm
need to explicitly include and link libsysfs.
Jack Morgenstein [Wed, 10 May 2006 17:06:53 +0000 (17:06 +0000)]
r7079: On kernels 2.6.9 and back, we didn't find a way to add sysfs attributes to
misc devices. If the abi version file does not exist, assume latest ABI to
make it possible to use librdmacm on such systems.
Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sean Hefty [Tue, 9 May 2006 18:25:10 +0000 (18:25 +0000)]
r7019: Introduce event channels. Event channels allow the application to direct
how RDMA CM events are reported, by directing events on different rdma_cm_id's
to different event channels. These are similar to completion channels used
in verbs.
Sean Hefty [Wed, 26 Apr 2006 22:54:45 +0000 (22:54 +0000)]
r6674: If librdmacm has an error processing an ESTABLISHED event, it will report a
CONNECT_ERROR event to the user. However, the kernel will list the cm_id
state as connected. This can result in librdmacm receiving a DISCONNECTED
event on a cm_id that it failed to fully connect from userspace. This event
should not be reported to the user.
This condition can occur when the remote side establishes a connection, then
disconnects before the local side processes the ESTABLISHED event. When the
ESTABLISHED event is finally processed, the local side will get a failure
transitioning the QP, causing librdmacm to report CONNECT_ERROR. Since the
connection was never reported as ESTABLISHED to the user, do not report the
DISCONNECTED event.
A similar situation exists between the CONNECT_RESPONSE and REJECTED events.
projects / ~shefty / librdmacm.git / log