]>
git.openfabrics.org - ~shefty/rdma-dev.git/log
Oren Weil [Wed, 21 Sep 2011 13:45:30 +0000 (16:45 +0300)]
staging: mei: Organize the initialization state machine.
moving the final state, clearing of the client maps and
updating of mei state out from mei_host_client_properties function.
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Oren Weil <oren.jer.weil@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Wed, 21 Sep 2011 07:17:04 +0000 (10:17 +0300)]
Staging: rtl8192e: off by one in rtl8192_get_channel_map()
COUNTRY_CODE_MAX is not a valid country code. We're off by one here.
This gets passed to Dot11d_Channelmap() where it's used as an offset
into the ChannelPlan[] array.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:56 +0000 (17:07 -0700)]
staging: brcm80211: simplified internal ioctl function once more
Code cleanup. Merged two functions.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:55 +0000 (17:07 -0700)]
staging: brcm80211: consistent naming of struct net_device *ndev
Code cleanup. Various names (ndev, net, dev) were used for the
same structure. Settled for 'ndev'.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:54 +0000 (17:07 -0700)]
staging: brcm80211: clarified fullmac io and event codes
Added comments to make code more readable.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:53 +0000 (17:07 -0700)]
staging: brcm80211: removed log after kzalloc()/kmalloc() failure
kzalloc/kmalloc already reports an allocation failure themselves.
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:52 +0000 (17:07 -0700)]
staging: brcm80211: removed likely/unlikely calls
There was no performance rationale to use these guys.
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:51 +0000 (17:07 -0700)]
staging: brcm80211: added endianness check flag to fullmac Makefile
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:50 +0000 (17:07 -0700)]
staging: brcm80211: removed two fullmac sparse spinlock warnings
By deleting three redundant functions. The spinlock was related to
event queue operation. Event queue data members were also renamed
to make their function more clear.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:49 +0000 (17:07 -0700)]
staging: brcm80211: remove global variables for data frame boundary
Put boundary settings in brcmf_bus structure
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:48 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_idletime
Use constant for idle time setting.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:47 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param for watchdog
Use constant to replace global variable used for watchdog polling
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:46 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_sdiod_drive_strength
Replaced the global variable with constant
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:45 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_dongle_memsize
remove unused module parameter brcmf_dongle_memsize and related code
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 23 Sep 2011 00:07:44 +0000 (17:07 -0700)]
staging: brcm80211: remove event handler thread from fullmac
Use work queue to defer cfg80211 event handle jobs
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 23 Sep 2011 00:07:43 +0000 (17:07 -0700)]
staging: brcm80211: remove unconditional code blocks from brcmfmac
Using a block statement to scope function variables is not
common in linux kernel development. Browsed through the brcmfmac
to remove those.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:42 +0000 (17:07 -0700)]
staging: brcm80211: more fullmac sparse endianness scan related changes
Annotated endianness on structures send/received to/from dongle.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:41 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings for struct sdpcm_shared
Structure that is received from dongle has been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:40 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings for struct brcmf_proto_cdc_ioctl
Structure that is send/received to/from dongle has been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:39 +0000 (17:07 -0700)]
staging: brcm80211: various fulmac sparse endianness fixes
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 23 Sep 2011 00:07:38 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings on dongle events
Structures received from dongle have been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:35 +0000 (10:31 -0700)]
Staging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code
Now that the transformation of the util driver is complete,
get rid of hv_cb_utils[] and other unneeded code.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:34 +0000 (10:31 -0700)]
Staging: hv: util: Properly handle util services in the util driver
Now, properly handle util services in the util driver and eliminate code
that will not be necessary. In the current code, util services were
all handled not as other vmbus devices (net, block) but rather through
special handling (channel setup etc.). In this patch we handle all
services using the standard Linux Driver Model.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:33 +0000 (10:31 -0700)]
Staging: hv: util: Perform some service specific init/deinit in probe/remove
In preparation for modifying the util driver to fully conform to the
Linux Driver Model, perform some service specific init and de-init
operations in util_probe()/util_remove() as opposed to in
init_hyperv_utils()/exit_hyperv_utils() as is currently done.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
David Kilroy [Mon, 19 Sep 2011 20:08:15 +0000 (21:08 +0100)]
staging: wlags49_h2: Support standard WEXT events
... instead of using IWEVCUSTOM. Use the defined events for
michael mic failure, association request info and association
response info.
Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
David Kilroy [Mon, 19 Sep 2011 20:08:14 +0000 (21:08 +0100)]
staging: wlags49_h2: Remove old WIRELESS_EXT support
Since the driver is now in-kernel remove support for building
against ancient WIRELESS_EXT versions.
Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kautuk Consul [Wed, 14 Sep 2011 03:26:21 +0000 (08:56 +0530)]
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT
If the usermode app does an ioctl over this serial device by
using TIOCMIWAIT, then the code will wait by setting the current
task state to TASK_INTERRUPTIBLE and then calling schedule().
This will be woken up by the qt2_process_modem_status on URB
completion when the port_extra->shadowMSR is set to the new
modem status.
However, this could result in a lost wakeup scenario due to a race
in the logic in the qt2_ioctl(TIOCMIWAIT) loop and the URB completion
for new modem status in qt2_process_modem_status.
Due to this, the usermode app's task will continue to sleep despite a
change in the modem status.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kevin McKinney [Sun, 18 Sep 2011 22:34:47 +0000 (18:34 -0400)]
Staging: bcm: Add size maximum size restrictions for IOCTL_IDLE_REQ
In the first alteration, the MAX_CNTL_PKT_SIZE is the
maximum size of the control packet in ->Adapter->txctlpacket[]
which is defined in InitAdapter(). This caps the size of
kmalloc memory allocation. In the second change, this max
cap fixes a potential memory corruption bug when subsequent
memset and memcpy calls are invoked.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kevin McKinney [Sun, 18 Sep 2011 22:34:46 +0000 (18:34 -0400)]
Staging: bcm: Add size minimum size restrictions for IOCTL_IDLE_REQ
If IoBuffer.InputLength is zero then this will cause an Oops when
we dereference the ZERO_SIZE_PTR. Or if it's smaller than
sizeof(struct link_request) then we would get memory corruption
when we set ->PLength in CopyBufferToControlPacket().
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alexander Thomas [Mon, 19 Sep 2011 14:56:51 +0000 (16:56 +0200)]
staging: usbip: fix up api changes that broke windows clients
Revert changes in definitions that were submitted on May 11 2011 and
committed on June 7 2011. No reason for the change in these values was
given in the patch comment, it broke compatibility with older
versions, and was difficult to detect by the simultaneous move of the
lines of code.
Signed-off-by: Alexander Thomas <alexander.thomas@esaturnus.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:28:08 +0000 (12:28 -0700)]
staging: brcm80211: sparse endianness warnings on fullmac bss info
Structure that is received from dongle has been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 16 Sep 2011 19:28:07 +0000 (12:28 -0700)]
staging: brcm80211: remove static global variables from dhd_sdio.c
Several global variables that were set but never initialized have
been removed.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 16 Sep 2011 19:28:06 +0000 (12:28 -0700)]
staging: brcm80211: remove global variable from bcmsdh_sdmmc.c
The source file contained some static global variables that were
needed per device handled by the driver. They have moved to the
struct brcmf_sdio_dev for that reason.
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 16 Sep 2011 19:28:05 +0000 (12:28 -0700)]
staging: brcm80211: remove for_each_bss() macro from brcmfmac driver
The macro was only used once in the code and has been removed for
clarity reading the code.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 16 Sep 2011 19:28:04 +0000 (12:28 -0700)]
staging: brcm80211: remove brcmfmac interface name override
The brcmfmac had a module parameter which could be used to override
the name of the wireless net device name and it defaults to 'wlan'.
This is considered rather useless, because what is in a name.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:28:03 +0000 (12:28 -0700)]
staging: brcm80211: remove fullmac module_param for ARP offload feature
Use macro to replace global variable for ARP offload configuration
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:28:02 +0000 (12:28 -0700)]
staging: brcm80211: remove _brcmf_sysioc_thread in fullmac
_brcmf_sysioc_thread is handling deferred jobs from 4 callers. Use
work queue to handle set_mac_address/set_multicast_list requests.
brcmf_add_if/brcmf_del_if never run in atomic context and can call
brcmf_op_if directly.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:28:01 +0000 (12:28 -0700)]
staging: brcm80211: fixed sparse endianness warnings on fullmac ratespec
Structure that is sent to the dongle has been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:28:00 +0000 (12:28 -0700)]
staging: brcm80211: fixed sparse endianness warnings on fullmac scb pars
Structure that is sent to the dongle has been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:27:59 +0000 (12:27 -0700)]
staging: brcm80211: fixed sparse endianness warnings on fullmac assoc pars
Structures that are sent to the dongle have been annotated.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:27:58 +0000 (12:27 -0700)]
staging: brcm80211: fixed sparse endianness warnings on fullmac scan pars
Three structures that are sent to the dongle have been annotated for correct
endianness: struct brcmf_iscan_params, brcmf_scan_params,
brcmf_cfg80211_scan_req.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:27:57 +0000 (12:27 -0700)]
staging: brcm80211: removed set_fs/get_fs/get_ds calls from brcmf_dev_ioctl()
brcmf_dev_ioctl() does not provide a user space buffer to
brcmf_netdev_ioctl_priv. Hence these calls are not necessary.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Fri, 16 Sep 2011 19:27:56 +0000 (12:27 -0700)]
staging: brcm80211: simplified brcmf_proto_ioctl()
Removed a function parameter since it was redundant.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:55 +0000 (12:27 -0700)]
staging: brcm80211: remove global variable brcmf_radio_up from fullmac
Remove unnecessary global variable
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:54 +0000 (12:27 -0700)]
staging: brcm80211: remove global variable brcmf_roam from fullmac
Remove unnecessary global variable
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:53 +0000 (12:27 -0700)]
staging: brcm80211: remove fullmac module_param for packet filter feature
Use constant values for packet filter configuration
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:52 +0000 (12:27 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_deferred_tx
Remove brcmf_deferred_tx as it should be always 1
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:51 +0000 (12:27 -0700)]
staging: brcm80211: remove fullmac module_param sd_f2_blocksize
Replaced the global variable with macro.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Franky Lin [Fri, 16 Sep 2011 19:27:50 +0000 (12:27 -0700)]
staging: brcm80211: remove SOFTAP code from fullmac
Dead code removal.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Fri, 16 Sep 2011 06:57:33 +0000 (08:57 +0200)]
drivers/staging/mei/interface.c: take size of pointed value, not pointer
Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *e;
type T;
identifier f;
@@
f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:17 +0000 (14:15 +0800)]
Staging: cx25821: cx25821-video.h: Fix long lines
Fix long function prototypes and line up arguments nicely.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:16 +0000 (14:15 +0800)]
Staging: cx25821: cx25821-video.h: Fix indent
Fix indent of function arguments.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:15 +0000 (14:15 +0800)]
Staging: cx25821: cx25821-video.h: Line up constant
Line up integer constant with others.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:14 +0000 (14:15 +0800)]
Staging: cx25821: Replace :? by if-else in cx25821-video.c
Replace :? operator by equivalent if-else statement where in improves
readability. Don't add else branch if it is not needed.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:13 +0000 (14:15 +0800)]
Staging: cx25821: Fix braces around statements in cx25821-video.c
Delete braces around single statements.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:12 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 35
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:11 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 34
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:10 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 33
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:09 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 32
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:08 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 31
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:07 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 30
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:06 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 29
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:05 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 28
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:04 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 27
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:03 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 26
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:02 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 25
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:01 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 24
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:15:00 +0000 (14:15 +0800)]
Staging: cx25821: Change indent with spaces to tabs 23
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:59 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 22
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:58 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 21
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:57 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 20
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:56 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 19
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:55 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 18
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:54 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 17
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:53 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 16
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:52 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 15
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:51 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 14
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:50 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 13
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:49 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 12
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:48 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 11
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:47 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 10
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:46 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 9
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:45 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 8
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:44 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 7
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:43 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 6
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:42 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 5
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:41 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 4
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:40 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 3
Change indent with spaces to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:39 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 2
Change indent with spaces to use tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:38 +0000 (14:14 +0800)]
Staging: cx25821: Change indent with spaces to tabs 1
Changed indent with spaces to use tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:37 +0000 (14:14 +0800)]
Staging: cx25821: Fix indent in comment
Change indent in comment to use tabs instead of spaces.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:36 +0000 (14:14 +0800)]
Staging: cx25821: Fix obscure line endings
Fix obscure line endings to less obscure ones. Rationale: readability.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:35 +0000 (14:14 +0800)]
Staging: cx25821: Fix function signatures
Fix long function signatures (over 80 characters) and indent them
properly.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Leonid V. Fedorenchik [Fri, 16 Sep 2011 06:14:34 +0000 (14:14 +0800)]
Staging: cx25821: Fix labels' placement in cx25821-video.c
Delete whitespace before labels.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Tue, 13 Sep 2011 07:49:57 +0000 (09:49 +0200)]
staging: brcm80211: introduced fullmac function get/set u32 to/from dongle
Code cleanup. Avoids repetition of same code fragment.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Tue, 13 Sep 2011 07:49:56 +0000 (09:49 +0200)]
staging: brcm80211: fullmac sparse endianness encryption keys check
Added support by making a distinction between a struct and its little
endian relative.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Tue, 13 Sep 2011 07:49:55 +0000 (09:49 +0200)]
staging: brcm80211: cleaned up function brcmf_cfg80211_get_key()
Unnecessary endianess conversion and struct member setting was deleted.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 15 Sep 2011 08:06:34 +0000 (10:06 +0200)]
staging: brcm80211: simplification of brcmf_netdev_ioctl_priv()
This function is only called from within the driver. Because of that
certain simplifications (not required to lock down user mem pages,
not required to check user permissions) could be performed.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Tue, 13 Sep 2011 07:49:53 +0000 (09:49 +0200)]
staging: brcm80211: separated public from private ioctl functions
net_device ioctl handler was called both by the OS as by the driver
itself. Split the ioctl handler into two functions to make code paths
more clear.
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Tue, 13 Sep 2011 07:49:52 +0000 (09:49 +0200)]
staging: brcm80211: macro cleanup in softmac rate.h
Substituted/moved/deleted macro's.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>