]>
git.openfabrics.org - ~emulex/infiniband.git/log
Jim Lieb [Wed, 12 Aug 2009 21:54:07 +0000 (14:54 -0700)]
Staging: vt665x: Typedef and macro cleanup Part 2
Clean up unused typedefs and macros to remove Win32'isms and
misc non-linux constructs. Text edits to referencing
source for less frequently used macros.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Wed, 12 Aug 2009 21:54:06 +0000 (14:54 -0700)]
Staging: vt665x: Typedef and macro cleanup Part 1
Clean up unused typedefs and macros to remove Win32'isms and
misc non-linux constructs. Text edits to referencing
source for less frequently used macros.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Wed, 12 Aug 2009 21:54:05 +0000 (14:54 -0700)]
Staging: vt6656: add TODO
Cc: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Wed, 12 Aug 2009 21:54:04 +0000 (14:54 -0700)]
Staging: vt6655: add TODO
Cc: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Wed, 12 Aug 2009 21:54:03 +0000 (14:54 -0700)]
Staging: vt665x: Text janitor in prep for driver merge, part 2
Text only changes to remove textual differences between the vt6655
and vt6656 trees in prep for driver merge.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Thu, 30 Jul 2009 17:30:32 +0000 (10:30 -0700)]
Staging: vt665x: Text janitor in prep for driver merge
These changes in vt6656 match changes in vt6655 to minimize text differences
prior to merging the two trees into a single driver source.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Cc: Forest Bond <forest@alittletooquiet.net>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Thu, 30 Jul 2009 17:27:21 +0000 (10:27 -0700)]
Staging: vt6655 textual cleanup in prep for driver merge
The vt6655 and vt6656 drivers are from a common origin but
have drifted apart with minor textual differences. There
are two changes:
s/DEVICE_PRT/DBG_PRT/g
and
s/byPktTyp/byPktType/g
This significantly reduces the differences between the two file sets
in preparation to merging the common code. A few whitespace and text bits were
also adjusted.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Cc: Forest Bond <forest@alittletooquiet.net>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Fri, 24 Jul 2009 00:22:42 +0000 (17:22 -0700)]
Staging: vt665x: 64bit compile fixes Part 2
Fix compile problems with 64bit. These issues could cause corrupted
address crashes. Cleanup definition use to use more portable kernel
typedefs etc.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jim Lieb [Fri, 24 Jul 2009 00:20:49 +0000 (17:20 -0700)]
Staging: vt665x: 64bit compile fixes Part 1
Fix compile problems with 64bit. These issues could cause corrupted
address crashes. In the process, replaced some definitions to use more
portable kernel types.
Signed-off-by: Jim Lieb <lieb@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jaswinder Singh Rajput [Fri, 14 Aug 2009 06:24:37 +0000 (11:54 +0530)]
Staging: otus: includecheck fix: drivers/staging/otus/usbdrv.h
fix the following 'make includecheck' warning:
drivers/staging/otus/usbdrv.h: linux/usb.h is included more than once.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Thu, 6 Aug 2009 19:22:01 +0000 (15:22 -0400)]
Staging: serqt_usb2: fix qt_open parameters
The parameter list for qt_open() was from the old non usb-serial
driver.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Thu, 6 Aug 2009 23:09:35 +0000 (16:09 -0700)]
Staging: udlfb: fix printk format warning
Fix printk format warning: use %td for ptrdiff:
drivers/staging/udlfb/udlfb.h:209: warning: format '%d' expects type 'int', but argument 3 has type 'long int'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alexander Beregalov [Thu, 6 Aug 2009 23:09:34 +0000 (16:09 -0700)]
Staging: rt2860: remove dependency on WIRELESS_EXT version
As the driver is in mainline now we can remove such dependencies.
WIRELESS_EXT is 22 now.
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike Galbraith [Fri, 31 Jul 2009 05:52:58 +0000 (07:52 +0200)]
Staging: rt2870sta interface names
The rest of the known universe prefers wlanN for wireless interface names, to
the point that some distro configuration tools, such as opensuse's Yast, don't
even allow the user to enter a name, and simply pre-select "wlan".
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Tue, 28 Jul 2009 15:52:56 +0000 (17:52 +0200)]
Staging: dst: correct error-handling code
dst_state_alloc returns an ERR_PTR value in an error case instead of NULL.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@match exists@
expression x, E;
statement S1, S2;
@@
x = dst_state_alloc(...)
... when != x = E
(
* if (x == NULL || ...) S1 else S2
|
* if (x == NULL && ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stoyan Gaydarov [Wed, 22 Jul 2009 03:02:27 +0000 (22:02 -0500)]
Staging: ARRAY_SIZE changes
These changes were a direct result of using a semantic patch
More information can be found at http://www.emn.fr/x-info/coccinelle/
Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Mon, 27 Jul 2009 19:59:48 +0000 (21:59 +0200)]
Staging: Correct use of ! and &
Correct priority problem in the use of ! and &.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E; constant C; @@
- !E & C
+ !(E & C)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Uwe Kleine-König [Thu, 23 Jul 2009 06:33:56 +0000 (08:33 +0200)]
Staging: fix typos "man[ae]g?ment" -> "management"
This patch was generated by running
git grep -E -l 'man[ae]g?ment' drivers/staging | xargs -r perl -p -i -e 's/\bman[ae]g?ment\b/management/g'
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Shan Wei [Fri, 24 Jul 2009 08:57:35 +0000 (16:57 +0800)]
Staging: usb-ip: vhci_hdc:Fix the returned error value
Compared with other drivers, the "ret" should be nagative and
returned. But in vhci_hdc, it always return 0;
I dont't use the driver, and I'm not familiar with the code.
Hope the patch is helpful.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Felipe Balbi [Tue, 21 Jul 2009 12:52:26 +0000 (15:52 +0300)]
Staging: cpc-usb: add one todo entry
we need to get rid of those driver-specific error codes
Signed-off-by: Felipe Balbi <me@felipebalbi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Felipe Balbi [Tue, 21 Jul 2009 12:52:25 +0000 (15:52 +0300)]
Staging: cpc-usb: convert comment style in cpcusb.h
Signed-off-by: Felipe Balbi <me@felipebalbi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Felipe Balbi [Tue, 21 Jul 2009 12:52:24 +0000 (15:52 +0300)]
Staging: cpc-usb: convert comment style in cpc_int.h
Signed-off-by: Felipe Balbi <me@felipebalbi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Felipe Balbi [Tue, 21 Jul 2009 14:35:50 +0000 (17:35 +0300)]
Staging: cpc-usb: convert comment style in cpc.h
Signed-off-by: Felipe Balbi <me@felipebalbi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brian G. Merrell [Tue, 21 Jul 2009 06:46:13 +0000 (00:46 -0600)]
Staging: USB-IP code cleanup
This includes fixes for all of the legit checkpatch.pl errors and
warnings. I have also included several of the suggestions from the
linux-kernel mailing list when the USB-IP code was first added.
Signed-off-by: Brian G. Merrell <bgmerrell@novell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Sat, 18 Jul 2009 15:25:30 +0000 (17:25 +0200)]
Staging: meilhaus: convert nested spin_lock_irqsave to spin_lock
If spin_lock_irqsave is called twice in a row with the same second
argument, the interrupt state at the point of the second call overwrites
the value saved by the first call. Indeed, the second call does not need
to save the interrupt state, so it is changed to a simple spin_lock.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression lock1,lock2;
expression flags;
@@
*spin_lock_irqsave(lock1,flags)
... when != flags
*spin_lock_irqsave(lock2,flags)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: David Kiliani <mail@davidkiliani.de>
Cc: Meilhaus Support <support@meilhaus.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 8 Aug 2009 13:40:50 +0000 (15:40 +0200)]
Staging: dream: Synaptics touchscreen: check that smbus is available
Check that SMBUS APIs are available in touchscreen driver.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arve Hjønnevåg [Sat, 8 Aug 2009 13:03:15 +0000 (15:03 +0200)]
Staging: dream: add support for input on GPIO pins
Support for input devices connected to GPIO pins. This adds support
for HTC Dream's keyboard and its trackball. Generic support already
exists for keyboard on GPIO, but this one is more advanced because it
can detect shadow key presses (and actually works with Dream :-).
(It also contains Kconfig/Makefile changes, including some that were
missing from previous commit. Sorry.)
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 8 Aug 2009 12:27:02 +0000 (14:27 +0200)]
Staging: Dream: separate Kconfig/Makefile into subdirectory
Separate Kconfig/Makefile glue from dream into subdirectory. I plan to
add few more drivers, and changing staging/Makefile each time sounds
like inviting conflicts.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jiri Slaby [Sat, 8 Aug 2009 09:33:58 +0000 (11:33 +0200)]
Staging: dream, fix buf overflow
In vfe_send_msg_no_payload there is a wrong struct vfe_message allocation.
It allocates only sizeof(pointer to vfe_message) for a whole structure.
Add a dereference to the sizeof to allocate sizeof(vfe_message).
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Tue, 4 Aug 2009 22:00:10 +0000 (00:00 +0200)]
Staging: dream: synaptics touchscreen for dream: documentation
This adds pointer to hardware documentation, and adds code comment
from Arve.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Tue, 21 Jul 2009 10:04:26 +0000 (12:04 +0200)]
Staging: HTC Dream: touchscreen: more cleanups
This separates coefficient computation into separate function, so that
main probe does not have 1001 variables, and is of a more reasonable
size.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Mon, 20 Jul 2009 21:59:11 +0000 (23:59 +0200)]
Staging: HTC Dream: Cleanup Dream touchscreen driver
This is first part of touchscreen cleanups. I did not remove
earlysuspend functionality for now (to help Google merge the changes).
I mainly introduced helpers to reduce code duplication, and split huge
functions into smaller ones.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arve Hjønnevåg [Mon, 20 Jul 2009 10:53:40 +0000 (12:53 +0200)]
Staging: HTC Dream: touchscreen driver for staging
This adds support for synaptic touchscreen, used in HTC dream
cellphone.
This is original version from Arve, fixed only to compile; I do have
cleaner version, but I broken something inside, and this will preserve
authorship better. I originally tried to push the driver directly to
input/touchscreen, but the driver has some issues with interrupt
handling that are more difficult to fix than I expected at first.
Signed-off-by: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Pavel Machek [Tue, 21 Jul 2009 10:38:46 +0000 (12:38 +0200)]
Staging: htc: Dream: limit Kconfig for only MSM platforms
Limit SMD communication glue to MSM platform. It is closely tied to
MSM architecture.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Mon, 14 Sep 2009 21:34:20 +0000 (14:34 -0700)]
Staging: hv: update the TODO file
Remove a few items that have already been resolved.
There are only a few checkpatch issues, they need to be resolved
by larger code logic changes that are not "simple" changes.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Sat, 12 Sep 2009 01:46:46 +0000 (21:46 -0400)]
Staging: hv: Remove List.h
List.h is no longer used and can be removed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Sat, 12 Sep 2009 01:46:45 +0000 (21:46 -0400)]
Staging: hv: remove use of internal list routines in RndisFilter
The hv driver has it's own linked list routines. This removes them
from RndisFilter.c
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Sat, 12 Sep 2009 01:46:44 +0000 (21:46 -0400)]
Staging: hv: remove more usages of internal list routines
The hv driver has it's own linked list routines. This removes them
from more places in hv.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Sat, 12 Sep 2009 01:46:43 +0000 (21:46 -0400)]
Staging: hv: remove use of internal list routines in NetVsc
The hv driver has it's own linked list routines. This removes them
from NetVsc and uses the kernels routines instead.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Haiyang Zhang [Tue, 8 Sep 2009 20:12:55 +0000 (20:12 +0000)]
Staging: hv: Add Haiyang's email to the TODO file
Add Haiyang's email to the TODO file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:53:59 +0000 (11:53 -0700)]
Staging: hv: remove function pointer typedefs from vmbus.h
It's amazing the hoops that people go through to make code work
when they don't opensource the whole thing. Passing these types
of function pointers around for no good reason is a mess, this needs
to be unwound as everything is now in the open.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:44:19 +0000 (11:44 -0700)]
Staging: hv: remove PFN_CHANNEL_CALLBACK
Come on people, it doesn't get simpler than this, why
have a typedef for something so tiny...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:28:55 +0000 (11:28 -0700)]
Staging: hv: remove function pointer typedefs from StorVscApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:24:48 +0000 (11:24 -0700)]
Staging: hv: remove function pointer typedefs from NetVscApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 18:18:10 +0000 (11:18 -0700)]
Staging: hv: remove function pointer typedefs from VmbusApi.h
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency. So just spell them all out, it makes the
code smaller and easier to understand overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 17:35:56 +0000 (10:35 -0700)]
Staging: hv: rename struct NETVSC_DEVICE
The Linux kernel doesn't have all caps structures, we don't like to
shout at our programmers, it makes them grumpy. Instead, we like to
sooth them with small, rounded letters, which puts them in a nice,
compliant mood, and makes them more productive and happier, allowing
them more fufilling lives overall.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 17:33:05 +0000 (10:33 -0700)]
Staging: hv: coding style cleanup for NetVsc.c
Still a lot of long lines, but that's nothing I can fix up at this time
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 16:17:52 +0000 (09:17 -0700)]
Staging: hv: coding style cleanup for RndisFilter.c
It's much better now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 15:37:47 +0000 (08:37 -0700)]
Staging: hv: coding style cleanup for storvsc_drv.c
Where's the hazard pay for cleaning up this mess...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 14:11:14 +0000 (07:11 -0700)]
Staging: hv: coding style cleanups for vmbus_drv.c
Almost clean.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 03:12:58 +0000 (20:12 -0700)]
Staging: hv: warn the world of a bug in the release function
All device release functions need to do something, if not, it's a bug.
By merely providing an "empty" release function, it gets the kernel to
shut up, but that's not solving the problem at all. Stick a big fat
WARN_ON(1); in there to get people's attention.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 2 Sep 2009 00:24:57 +0000 (17:24 -0700)]
Staging: hv: coding style cleanup for Channel.c
All clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 23:34:56 +0000 (16:34 -0700)]
Staging: hv: coding style fixes for blkvsc_drv.c
There are still some very long lines, someone needs to unwind the
logic there to resolve that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 05:31:22 +0000 (22:31 -0700)]
Staging: hv: reorg StorVsc.c
This gets rid of all of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 05:25:48 +0000 (22:25 -0700)]
Staging: hv: coding style cleanups for StorVsc.c
Some one owes me a lot of beer, or a nice bottle of rum for
all of this crud cleanup...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:56:16 +0000 (21:56 -0700)]
Staging: hv: TODO: add some more items
Add List.h and RingBuffer.h removal items.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:51:50 +0000 (21:51 -0700)]
Staging: hv: reorg ChannelMgmt a bit
This gets rid of the unneeded typedef and the forward declarations,
saving a bit of code file size.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:47:21 +0000 (21:47 -0700)]
Staging: hv: coding style cleanups for ChannelMgmt.c
There are still some too-long lines here, hopefully they will get
resolved later.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:11:12 +0000 (21:11 -0700)]
Staging: hv: reorganize netvsc_drv.c
Saves space by getting rid of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 04:09:45 +0000 (21:09 -0700)]
Staging: hv: coding style cleanups for netvsc_drv.c
There are still some horrible long lines in here, which some simple
code reworking will make smaller and easier to understand.
Also note the FIXME in struct netvsc_driver_context...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 03:23:33 +0000 (20:23 -0700)]
Staging: hv: fix coding style issues in Hv.c
Lots of cleanups.
Note, the use of volatile still needs to be resolved, and
possibly the #ifdef could be done a bit "better".
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 00:37:58 +0000 (17:37 -0700)]
Staging: hv: code reduction from Vmbus.c
Reorder some functions to get rid of all of the forward declarations.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 1 Sep 2009 00:37:18 +0000 (17:37 -0700)]
Staging: hv: coding style cleanups on Vmbus.c
It's now much nicer and cleaner.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Mon, 31 Aug 2009 18:40:14 +0000 (11:40 -0700)]
Staging: hv: coding style cleanups for Connection.c
Everything is clean except for some very long lines that
need a bit more code rework to resolve. That will have to be done by
someone that can test the code.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:48 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from StorVsc.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:27 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from RndisFilter.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:26:11 +0000 (16:26 -0700)]
Staging: hv: remove typedefs from ChannelMgmt.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:25:39 +0000 (16:25 -0700)]
Staging: hv: coding style cleanups of ChannelInterface.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:25:21 +0000 (16:25 -0700)]
Staging: hv: coding style cleanups of BlkVsc.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:48 +0000 (16:24 -0700)]
Staging: hv: move VmbusPacketFormat.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:34 +0000 (16:24 -0700)]
Staging: hv: move VmbusChannelInterface.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:24:16 +0000 (16:24 -0700)]
Staging: hv: move VmbusApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:49 +0000 (16:23 -0700)]
Staging: hv: move StorVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:17 +0000 (16:23 -0700)]
Staging: hv: move NetVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:59 +0000 (16:22 -0700)]
Staging: hv: move logging.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:45 +0000 (16:22 -0700)]
Staging: hv: move List.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:33 +0000 (16:22 -0700)]
Staging: hv: remove ChannelMessages.h
It's only ever used within the ChannelMgmt.h file, so pull it
into there.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:21:33 +0000 (16:21 -0700)]
Staging: hv: move nvspprotocol.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:53 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in nvspprotocol.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:34 +0000 (16:20 -0700)]
Staging: hv: fix coding style issues in nvspprotocol.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:07 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in StorVscApi.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:19:17 +0000 (16:19 -0700)]
Staging: hv: fix coding style issues in StorVscApi.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:02:36 +0000 (16:02 -0700)]
Staging: hv: remove typedefs from VmbusPacketFormat.h
All spiffied up now, shines like a brass button on the bump of a barge's
bilge.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:01:23 +0000 (16:01 -0700)]
Staging: hv: fix coding style issues in VmbusPacketFormat.h
Heh, volatiles, like that was a good idea... Turns out they were not
even used, wierd stuff.
All clean except for the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:00:24 +0000 (16:00 -0700)]
Staging: hv: fix typedefs in vstorage.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:59:39 +0000 (15:59 -0700)]
Staging: hv: fix remaining style issue in ChannelInterface.h
It snuck in with the other typedef cleanups, sorry about that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:52 +0000 (15:58 -0700)]
Staging: hv: move vstorage.h to hv dir
Move it out of the include subdir, it doesn't need to
be there.
No code was changed in the move.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:15 +0000 (15:58 -0700)]
Staging: hv: fix up typedefs in NetVscApi.h
It's now all clean from a coding style standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:57:15 +0000 (15:57 -0700)]
Staging: hv: fix up coding style issues in NetVscApi.h
Everything but the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:55:48 +0000 (15:55 -0700)]
Staging: hv: fix up some coding style issues in logging.h
It's now clean.
Well, from a coding style guide, not from a logic standpoint, the whole
file needs to be tossed overboard and cheered on as the sharks tear it
to individual bits.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:16:04 +0000 (15:16 -0700)]
Staging: hv: typedef removal for ChannelMessages.h
ChannelMessages.h is now coding style clean.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:14:51 +0000 (15:14 -0700)]
Staging: hv: codingsyle cleanups for ChannelMessages.h
Everything but the typedefs are taken care of.
Also a number of unused defines were removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:17:36 +0000 (12:17 -0700)]
Staging: hv: typedef removal for VmbusApi.h
The function pointers still have ugly names, but the structures
are now cleaned up.
Note, a comment was added where the driver structure is pointing
at a problem that needs to be fixed up later in the code.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:16:33 +0000 (12:16 -0700)]
Staging: hv: coding style cleanups for VmbusApi.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: typedef removal from VmbusChannelInterface.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: coding style cleanups for VmbusChannelInterface.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:17 +0000 (12:15 -0700)]
Staging: hv: move HvStatus.h into hv_api.h
It doesn't need to be a standalone file anymore.
No code changed, only moving things around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:14:11 +0000 (12:14 -0700)]
Staging: hv: coding style cleanups for HvStatus.h
Ugh, what a mess, it's all better now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:13:27 +0000 (12:13 -0700)]
Staging: hv: create hv_api.h
Merge the different include/Hv*Api.h files together into
hv_api.h as they really don't justify separate files.
No code was changed here, only moving stuff around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:12:31 +0000 (12:12 -0700)]
Staging: hv: remove volatile usage from HvSynicApi.h
It's pretty pointless as no one is using this structure, but even so
the use of volatile is so wrong here it's sad...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>