git.openfabrics.org - ~shefty/rdma-win.git/log

libibverbs/device: destroy completion channel when closing device

From: Sean Hefty <sean.hefty@intel.com>

ibv_close_device should destroy the completion channel
when closing the device and freeing the memory.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@2689 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 05:06:11 +0000 (05:06 +0000)]

dapl: use private_data_len for mem copies

From: Sean Hefty <sean.hefty@intel.com>

When copying private_data out of rdma_cm events, use the
reported private_data_len for the size, and not IB maximums.
This fixes a bug running over the librdmacm on windows, where
DAPL accessed invalid memory.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@2688 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 05:05:03 +0000 (05:05 +0000)]

dapl/cma: fix referencing freed address

From: Sean Hefty <sean.hefty@intel.com>

DAPL uses a pointer to reference the local and remote addresses
of an endpoint.  It expects that those addresses are located
in memory that is always accessible.  Typically, for the local
address, the pointer references the address stored with the DAPL
HCA device.  However, for the cma provider, it changes this pointer
to reference the address stored with the rdma_cm_id.

This causes a problem when that endpoint is connected on the
passive side of a connection.  When connect requests are given
to DAPL, a new rdma_cm_id is associated with the request.  The
DAPL code replaces the current rdma_cm_id associated with a
user's endpoint with the new rdma_cm_id.  The old rdma_cm_id is
then deleted.  But the endpoint's local address pointer still
references the address stored with the old rdma_cm_id.  The
result is that any reference to the address will access freed
memory.

Fix this by keeping the local address pointer always pointing
to the address associated with the DAPL HCA device.  This is about
the best that can be done given the DAPL interface design.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@2687 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 05:04:08 +0000 (05:04 +0000)]

librdmacm: set private_data_len

From: Sean Hefty <sean.hefty@intel.com>

Set the private_data_len for reported events. This allows
DAPL to use the value when copying private data.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@2686 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 04:58:32 +0000 (04:58 +0000)]

dapl: move close device after async thread is done using it

Before calling ibv_close_device, wait for the asynchronous
processing thread to finish using the device. This prevents
a use after free error.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
git-svn-id: svn://openib.tc.cornell.edu/gen1@2685 ad392aa1-c5ef-ae45-8dd8-e69d62a5ef86

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 01:43:30 +0000 (17:43 -0800)]

pop

commit | commitdiff | tree

Sean Hefty [Fri, 29 Jan 2010 01:43:30 +0000 (17:43 -0800)]

pop

Clone of Windows SVN development tree

RSS Atom