]>
git.openfabrics.org - ~shefty/rdma-dev.git/log
Benjamin Adolphi [Sat, 6 Feb 2010 14:12:32 +0000 (15:12 +0100)]
Staging: comedi: rti800: more Checkpatch cleanups
This fixes all checkpatch issues in the rti800 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:53:34 +0000 (10:53 -0800)]
Staging: rar_register: add suspend and resume functions
Add suspend and resume functions (which are currently stubs
returning -ENOSYS)
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:53:18 +0000 (10:53 -0800)]
Staging: rar_register: fix checkpatch errors and debug program file
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:53:00 +0000 (10:53 -0800)]
Staging: rar_register: fix checkpatch errors and debug header file
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:52:46 +0000 (10:52 -0800)]
Staging: rar_register: provide better explanation in Kconfig
Provides a better explanation of what this
driver is for in the Kconfig file
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:52:26 +0000 (10:52 -0800)]
Staging: rar_register: renaming directory to rar_register
Renames the directory in which the driver files
are located; again for clarity.
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 5 Feb 2010 18:52:09 +0000 (10:52 -0800)]
staging: rar_register: renaming driver to rar_register
Patch renames rar_driver to rar_register to clarifiy and differentiate
from rar_handler that will be submitted later
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 12 Feb 2010 01:15:14 +0000 (17:15 -0800)]
Staging: mimio: remove the mimio driver
It turns out that Mimio has a userspace solution for this product using
libusb, and the in-kernel driver is just getting in the way now and
causing problems. So they have asked that the in-kernel driver be
removed. As the staging driver wasn't quite working anyway, and Mimio
supports their libusb solution for all distros, I am removing the
in-kernel driver.
The libusb solution can be downloaded from:
http://www.mimio.com/downloads/mimio_studio_software/linux.asp
Cc: <mwilder@cs.nmsu.edu>
Cc: Phil Hannent <phil@hannent.co.uk>
Cc: Marc Rousseau <Marc.Rousseau@mimio.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: fix coding style issues in dt3155_io.c
This fixes up the sparse and coding style issues found in the
dt3155_io.c file.
No code is changed, only formatting and removing unused code.
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: replace u_int and u_long usage
Use u32 and u64 instead, that's the proper thing to do.
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:41:38 +0000 (12:41 -0800)]
Staging: dt3155: replace u_char usage
Use u8 instead, that's the proper thing to do.
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:38:13 +0000 (12:38 -0800)]
Staging: dt3155: coding cleanups for dt3155_io.h
This fixes up some coding style issues in the dt3155_io.h file
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 9 Feb 2010 20:37:25 +0000 (12:37 -0800)]
Staging: dt3155: fix build warnings
This fixes the build warnings in the dt3155 driver
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sun, 7 Feb 2010 16:51:51 +0000 (08:51 -0800)]
Staging: comedi: ssc_dnp: fixed a brace coding style issue
Fixed a coding style issue.
Created during the keynote presentation at FOSDEM 2010
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 6 Feb 2010 15:17:06 +0000 (16:17 +0100)]
Staging: comedi: ni_pcidio: Checkpatch cleanups
This fixes almost all checkpatch issues in the ni_pcidio comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 6 Feb 2010 14:08:46 +0000 (15:08 +0100)]
Staging: comedi: rti802: Checkpatch cleanups
This fixes all checkpatch issues in the rti802 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 6 Feb 2010 14:02:50 +0000 (15:02 +0100)]
Staging: comedi: dt2815: Checkpatch cleanups
This fixes all checkpatch issues in the dt2815 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Chihau Chau [Fri, 5 Feb 2010 18:23:48 +0000 (15:23 -0300)]
Staging: samsung-laptop: fix coding style issues
This fixes some lines over 80 characters coding style issues.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Yong Zhang [Fri, 5 Feb 2010 13:52:40 +0000 (21:52 +0800)]
Staging: rt2860: correct onstack wait_queue_head declaration
Use DECLARE_WAIT_QUEUE_HEAD_ONSTACK to make lockdep happy
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alexander Beregalov <a.beregalov@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tim Schofield [Thu, 4 Feb 2010 19:57:09 +0000 (19:57 +0000)]
Staging: rtl8192e: fix spacing style issues in r8180_93cx6.c
This is a patch to the r8180_93cx6.c file that fixes up spacing issue
warnings found by the checkpatch.pl tool
Signed-off-by: Tim Schofield <tim@weberpafrica.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Paul Elms [Thu, 4 Feb 2010 08:24:28 +0000 (08:24 +0000)]
Staging: comedi: fix brace coding style in comedi_fops.c
This patch to the comedi_fops.c file fixes a brace warning found by the checkpatch.pl tool
Signed-off-by: Paul Elms <paul@uprocera.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
tony burrows [Tue, 2 Feb 2010 16:52:49 +0000 (16:52 +0000)]
Staging: comedi: fix brace coding style issues in ni_labpc.c
This patch fixes all of the brace style warnings found by the
checkpatch.pl tool
Signed-off-by: Tony Burrows <tony@tonyburrows.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Tue, 2 Feb 2010 07:22:14 +0000 (23:22 -0800)]
Staging: Fix continuation line formats
String constants that are continued on subsequent lines with \
are not good.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Thu, 4 Feb 2010 11:33:49 +0000 (11:33 +0000)]
Staging: wlan-ng: minor cleanups
Remove iw_handle_def private initialisations as they are no longer need
these.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Sun, 31 Jan 2010 20:02:08 +0000 (12:02 -0800)]
Staging: Fix continuation line formats
String constants that are continued on subsequent lines with \
are not good.
Fixed a "is tryied" / tried typo
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sun, 31 Jan 2010 23:04:14 +0000 (00:04 +0100)]
Staging: comedi: adq12b: Checkpatch cleanups 2
This fixes all checkpatch issues in the adq12b comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sun, 31 Jan 2010 22:29:28 +0000 (23:29 +0100)]
Staging: comedi: fl512: Checkpatch cleanups
This fixes all checkpatch issues in the fl512 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 30 Jan 2010 12:03:20 +0000 (13:03 +0100)]
Staging: comedi: ni_65xx: Checkpatch cleanups
This fixes all checkpatch issues in the ni_65xx comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 30 Jan 2010 11:40:29 +0000 (12:40 +0100)]
Staging: comedi: ni_670x: Checkpatch cleanups
This fixes all checkpatch issues in the ni_670x comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Thu, 28 Jan 2010 23:42:30 +0000 (00:42 +0100)]
Staging: comedi: ni_660x: Checkpatch cleanups
This fixes all checkpatch issues in the ni_660x comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Thu, 28 Jan 2010 23:28:46 +0000 (00:28 +0100)]
Staging: comedi: poc: Checkpatch cleanups
This fixes all checkpatch issues in the poc comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Thu, 28 Jan 2010 23:17:06 +0000 (00:17 +0100)]
Staging: comedi: pcm3730: Checkpatch cleanups
This fixes all checkpatch issues in the pcm3730 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Thu, 28 Jan 2010 23:16:19 +0000 (00:16 +0100)]
Staging: comedi: pcm3724: Checkpatch cleanups
This fixes all checkpatch issues in the pcm3724 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:51:35 +0000 (21:21 +0530)]
Staging: ramzswap: Update copyright notice
Update copyright notice.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:49:59 +0000 (21:19 +0530)]
Staging: ramzswap: Handle case for invalid backing swap
Currently, we crash (issue BUG_ON) if backing swap
disk size is zero. This can happen is user specified
an extended partition or simply a bad disk as backing
swap. A crash is really an unpleasant surprise to user
for such trivial problems.
Now, we check for this condition and simply fail device
initialization if this is the case.
Additional cleanups:
* use static for all functions
* remove extra newline between functions
* memset backing_swap_name to NULL on device reset
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:43:41 +0000 (21:13 +0530)]
Staging: ramzswap: Remove redundant check for zero page
ramzswap_free_page() already handles the case for zero filled
pages. So, remove redundant logic for the same in ramzswap_write().
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:43:40 +0000 (21:13 +0530)]
Staging: ramzswap: Return proper error code on device create failure
Currently, we return 0 if create_device() fails and 1 otherwise.
Now, proper error code is returned from create_device() and the
same is propagated as module error code from ramzswap_init().
Also added some cleanups for ramzswap_init(), improving function
structure.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:43:39 +0000 (21:13 +0530)]
Staging: ramzswap: Set block size to PAGE_SIZE
ramzswap block size needs to be set equal to PAGE_SIZE to
avoid receiving any unaligned block I/O requests (happens
due to readahead logic during swapon). These unaligned
accesses produce unnecessary I/O errors, scaring users.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:43:38 +0000 (21:13 +0530)]
Staging: ramzswap: Flush block device before reset
Make sure we flush block device before freeing all metadata
during reset ioctl.
Signed-off-by: Nitin Gupta <ngupta@vflar.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nitin Gupta [Thu, 28 Jan 2010 15:43:37 +0000 (21:13 +0530)]
Staging: ramzswap: Use lock for 64-bit stats
64-bit stats corruption was observed when ramzswap was
used on SMP systems. To prevent this, use separate spinlock
to protect these stats.
Also, replace stat_*() with rzs_stat*() to avoid possible
conflict with core kernel code.
Eventually, these will be converted to per-cpu counters
if this driver finds use on large scale systems and this
locking is found to affect scalability.
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Larry Finger [Mon, 25 Jan 2010 19:11:49 +0000 (13:11 -0600)]
Staging: r8187se: Fix a faulty if and do additional cleanups
Cleanup the driver and fix a faulty if statement.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Tested by: Bernhard Schiffner <bernhard@schiffner-limbach.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
d binderman [Tue, 26 Jan 2010 10:00:25 +0000 (10:00 +0000)]
Staging: otus: fix memory leak
Fix memory leak in drivers/staging/otus
Signed-off-by: David Binderman <dcb314@hotmail.com>
Himanshu [Sat, 23 Jan 2010 12:22:02 +0000 (17:52 +0530)]
Staging: usbip: Seperate usbip config debug from CONFIG_USB_DEBUG
Signed-off-by: Himanshu <himanshu@symmetricore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Himanshu Chauhan [Sat, 23 Jan 2010 05:06:56 +0000 (10:36 +0530)]
Staging: usbip: Remove dead code
This patch removes the dead uncompiled code in usbip_common.c
Signed-off-by: Himanshu Chauhan <himanshu@symmetricore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Himanshu Chauhan [Fri, 22 Jan 2010 21:22:41 +0000 (02:52 +0530)]
Staging: usbip: use print_hex_dump() instead of open coding it.
Signed-off-by: Himanshu Chauhan <himanshu@symmetricore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Himanshu Chauhan [Fri, 22 Jan 2010 20:21:57 +0000 (01:51 +0530)]
Staging: usbip: minor code cleanup
Signed-off-by: Himanshu Chauhan <himanshu@symmetricore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:35 +0000 (15:35 +0000)]
Staging: et131x_kill MAC_STAT_t
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:30 +0000 (15:35 +0000)]
Staging: et131x: kill off the rxmac ctrl type
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:24 +0000 (15:35 +0000)]
Staging: et131x: kill the rxmac ERROR_REG_t
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:19 +0000 (15:35 +0000)]
Staging: et131x: Kill MIF_CTL_t
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:13 +0000 (15:35 +0000)]
Staging: et131x: Kill the SPACE_AVAIL type
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:08 +0000 (15:35 +0000)]
Staging: et131x: Kill off the rxq_diag types
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:35:02 +0000 (15:35 +0000)]
Staging: et131x: Kill of the MCIF types
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:57 +0000 (15:34 +0000)]
Staging: et131x: kill off RXMAC_PF_CTRL_t
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:51 +0000 (15:34 +0000)]
Staging: et131x: Kill rxmac crc fields
More we don't need
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:46 +0000 (15:34 +0000)]
Staging: et13x: kill off TXMAC_ERR_INT_t
This completes the structures within the txmac block so we can now
propogate a name change and type removal up a layer and clean up TXMAC as
well
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:40 +0000 (15:34 +0000)]
Staging: et131x: Kill off the TXMAC_ERR_t type
This is another one we don't really need to do much to get rid of
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:35 +0000 (15:34 +0000)]
Staging: et131x: kill txmac err count typedef
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:29 +0000 (15:34 +0000)]
Staging: et131x: Kil the txmac type
Only used for one trivial thing so turn that into something trivial instead
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:24 +0000 (15:34 +0000)]
Staging: et131x: Collapse all the function definitions into one place
We have lots of tiny files right now that could be one
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:18 +0000 (15:34 +0000)]
Staging: et131x: Kill unused error defines
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:13 +0000 (15:34 +0000)]
Staging: et131x: kill MP_ERR_COUNTERS which is unused
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:07 +0000 (15:34 +0000)]
Staging: et131x: Kill off RX_RING_t
This completes the typedef clean up of the rx specific structures, although
there is plenty do on field names and the like
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:34:02 +0000 (15:34 +0000)]
Staging: et131x: clean up the pkt_desc_stat_t types
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:56 +0000 (15:33 +0000)]
Staging: et131x: Clean up the fbr lookup table
All the subtypes are sane so just turn it into something struct and linux
like
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:51 +0000 (15:33 +0000)]
Staging: et131x: Fix rx_status typing
Use the proper pointer types for the higher level pointers to the rx_status
object and kill casts
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:45 +0000 (15:33 +0000)]
Staging: et131x: rx_status_block_t is now clean
So kill off the top level type and turn it into a struct
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:40 +0000 (15:33 +0000)]
Staging: et131x: kill off the rx interrupt state enum
Another verbose enum we don't need
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:34 +0000 (15:33 +0000)]
Staging: et131x: Clean up the rx status word types
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:29 +0000 (15:33 +0000)]
Staging: et131x: Kill MAC_STAT_t
All the contents of this type are now clean, so kill the top level type
as well
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:23 +0000 (15:33 +0000)]
Staging: et131x: Kill off MMC_t
The contents of MMC_t are clean so kill off the MMC_t typedef
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:18 +0000 (15:33 +0000)]
Staging: et131x: Kill off TXDMA_t
All the contents are clean so kill off the top level typedefs
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:12 +0000 (15:33 +0000)]
Staging: et131x: GLOBAL_t is now sane so kill the GLOBAL_t itself
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:07 +0000 (15:33 +0000)]
Staging: et131x: kill EXP_ROM
This is another unused type for the bin
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:33:01 +0000 (15:33 +0000)]
Staging: et131x: Kill off the rxdma type
We have a clean struct of this now so turn the top level typedefs into a
struct
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:32:55 +0000 (15:32 +0000)]
Staging: et131x: Clean up rxdma_csr
This is another set of flags as typedef that can be cleaned up.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:32:50 +0000 (15:32 +0000)]
Staging: et131x: fbr_desc is now only sane types
Clean up the typdef for fbr_desc itself so we know it is done
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:32:44 +0000 (15:32 +0000)]
Staging: et131x: kill of FBR_WORD2
This is only used meaningfully as a definition, we never mask and fetch the
bits apart
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Mon, 18 Jan 2010 15:32:39 +0000 (15:32 +0000)]
Staging: et131x: kill off the FBR_NUM_DES type
This is another 10 bit value with the high bits clear, and where the
type doesn't get used anywhere properly anyway
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dave Airlie [Wed, 20 Jan 2010 22:29:10 +0000 (17:29 -0500)]
Staging: crystalhd: fix build on powerpc
Add necessary include to fix build on PowerPC
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Mon, 18 Jan 2010 11:23:20 +0000 (14:23 +0300)]
Staging: rtl8187se: fix if statement
I removed a misplace semicolon. It is clear from the indentation that
TxPwrTracking87SE() was only supposed to be called if CheckTxPwrTracking()
returned true.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ben Hutchings [Mon, 18 Jan 2010 03:25:56 +0000 (03:25 +0000)]
Staging: rt{2860,2870}sta: Use request_firmware() to load firmware
When originally introduced into staging, these drivers had custom
firmware-loading code which checked a version number and CRC at the
end of each blob. This reintroduces those checks, using crc-ccitt
instead of custom code.
The removed firmware will be added to the linux-firmware.git
repository.
Based on work by Darren Salt <linux@youmustbejoking.demon.co.uk>.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Tested-By: Darren Salt <linux@youmustbejoking.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ben Hutchings [Mon, 18 Jan 2010 02:50:24 +0000 (02:50 +0000)]
Staging: rt2870sta: constify RTUSBMultiWrite(), RTUSBFirmwareWrite()
These functions do not modify the data they are passed.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Sun, 17 Jan 2010 15:50:10 +0000 (16:50 +0100)]
Staging: serqt_usb2: Two branches the same in qt_set_termios()
Regardless of the condition, the branches executed the same code
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Sun, 17 Jan 2010 15:44:37 +0000 (16:44 +0100)]
Staging: rt2860/sta_ioctl.c: Two branches the same in rt_ioctl_giwscan()
Regardless of the condition, the branches execute the same code
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:51 +0000 (13:04 +0000)]
Staging: comedi: pcl818: Remove unneeded chanlist_len check
For AI command testing, the driver does not need to range-check the
length of the channel list as the comedi core has already checked it.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:50 +0000 (13:04 +0000)]
Staging: comedi: pcl816: Check channel list in AI command test
Check the channel list is valid in step 5 of the AI command test.
Split function check_and_setup_channel_list() in two. Also, remove
unnecessary chanlist_len tests in step 3 of the AI command test as the
comedi core has already checked it.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:49 +0000 (13:04 +0000)]
Staging: comedi: pcl812: Update MUX for multi-channel AI command
For multi-channel AI commands, the interrupt handler is missing code to
switch to the next channel. Add some (untested) code to handle this.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:48 +0000 (13:04 +0000)]
Staging: comedi: adv_pci1710: Remove unneeded chanlist_len check
For AI command testing, the driver does not need to range-check
the length of the channel list as the comedi core has already
checked it.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:47 +0000 (13:04 +0000)]
Staging: comedi: adv_pci1710: Correct AI scan count and channel checks
For AI commands, the internal channel list used to check incoming
data was only set up partially if the channel list contained
repeats. Set it up fully. Also the current scan position was not
updated properly when moving a block of data from the FIFO unless
a whole number of scans was moved.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:46 +0000 (13:04 +0000)]
Staging: comedi: pcl818: Correct AI scan counting and channel checks
For AI commands, the scan counter should be updated after every
scan. It was being updated after every sample except for DMA mode
where it was being updated after every repeated segment of the
channel list.
Also AI commands with multiple channels were being terminated with
an error prematurely except in DMA mode. This was because the
driver was comparing channel numbers received from the hardware
(combined with the sample value) with the expected channel numbers
to check for a "channel dropout". This test was failing
incorrectly because the driver was not keeping the current position
within the (repeated segment of the) channel list up to date.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:45 +0000 (13:04 +0000)]
Staging: comedi: pcl816: Correct AI scan counting
For AI commands, the scan counter should be updated after every
scan. In DMA mode, it was being updated after every repeated
segment of the channel list. In non-DMA mode, it was being updated
after every sample.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ian Abbott [Wed, 20 Jan 2010 13:04:44 +0000 (13:04 +0000)]
Staging: comedi: pcl812: Correct AI scan counting
The AI scan counter should be updated after every completed scan,
not after every channel. Keep track of current channel.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Tue, 19 Jan 2010 20:46:48 +0000 (21:46 +0100)]
Staging: Comedi: G1-3 status registers not read in ni_gpct_to_660x_register()
Read from the right status register
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Mon, 18 Jan 2010 21:32:07 +0000 (22:32 +0100)]
Staging: comedi: pcl730: Checkpatch cleanups
This fixes all checkpatch issues in the pcl730 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Mon, 18 Jan 2010 11:57:42 +0000 (12:57 +0100)]
Staging: comedi: pcl725: Checkpatch cleanups
This fixes all checkpatch issues in the pcl725 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Mon, 18 Jan 2010 11:48:16 +0000 (12:48 +0100)]
Staging: comedi: pcl724: Checkpatch cleanups
This fixes all checkpatch issues in the pcl724 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Sat, 16 Jan 2010 17:58:58 +0000 (18:58 +0100)]
Staging: comedi: pcl711: Checkpatch cleanups
This fixes some checkpatch issues in the pcl711 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Sat, 16 Jan 2010 15:59:22 +0000 (16:59 +0100)]
Staging: go7007: Eliminate useless code
The variable s is initialized twice to the same (side effect-free)
expression. Drop one initialization.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@
x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Benjamin Adolphi [Fri, 15 Jan 2010 17:03:35 +0000 (18:03 +0100)]
Staging: comedi: rti800: Checkpatch cleanups
This fixes some checkpatch issues in the rti800 comedi driver.
Signed-off-by: Benjamin Adolphi <b.adolphi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>