From: Sudip Mukherjee Date: Tue, 18 Nov 2014 13:47:07 +0000 (+0530) Subject: can: xilinx_can: fix comparison of unsigned variable X-Git-Tag: v3.18-rc6~9^2~11^2~11 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=fb3ec7ba5a665c280f7299a36460449038fc1083;p=~emulex%2Finfiniband.git can: xilinx_can: fix comparison of unsigned variable The variable err was of the type u32. It was being compared with < 0, and being an unsigned variable the comparison would have been always false. Moreover, err was getting the return value from set_reset_mode() and xcan_set_bittiming(), and both are returning int. Signed-off-by: Sudip Mukherjee Reviewed-by: Michal Simek Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 5e8b5609c06..47b2f801d12 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev) static int xcan_chip_start(struct net_device *ndev) { struct xcan_priv *priv = netdev_priv(ndev); - u32 err, reg_msr, reg_sr_mask; + u32 reg_msr, reg_sr_mask; + int err; unsigned long timeout; /* Check if it is in reset mode */