From: Al Viro Date: Mon, 7 Jun 2010 03:19:04 +0000 (-0400) Subject: leak in hostfs_unlink() X-Git-Tag: v2.6.36-rc1~304^2~37 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=f8d7e1877e5121841bc9a4d284a04dbc13f45bea;p=~shefty%2Frdma-dev.git leak in hostfs_unlink() Signed-off-by: Al Viro --- diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 79783a0b2f4..8130ce93a06 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -622,11 +622,12 @@ int hostfs_unlink(struct inode *ino, struct dentry *dentry) char *file; int err; - if ((file = dentry_name(dentry)) == NULL) - return -ENOMEM; if (append) return -EPERM; + if ((file = dentry_name(dentry)) == NULL) + return -ENOMEM; + err = unlink_file(file); __putname(file); return err;