From: Arlin Davis <arlin.r.davis@intel.com>
Date: Wed, 26 Oct 2011 20:03:50 +0000 (-0700)
Subject: scm: dat_psp_create returns wrong error code on bind/listen failure
X-Git-Tag: dapl-2.0.34-1~9
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=f179ce281b382f005d1553d2401b05f50284aede;p=~ardavis%2Fdapl.git

scm: dat_psp_create returns wrong error code on bind/listen failure

The SCM provider changed to return DAT_INVALID_PARAMTER instead of
incorrect DAT_CONN_QUAL_UNAVAILABLE error code on any bind or
listen failure.

Signed-off-by: Arlin Davis <arlin.r.davis@intel.com>
---

diff --git a/dapl/openib_scm/cm.c b/dapl/openib_scm/cm.c
index 968d9b9..b9cb1bc 100644
--- a/dapl/openib_scm/cm.c
+++ b/dapl/openib_scm/cm.c
@@ -991,13 +991,14 @@ dapli_socket_listen(DAPL_IA * ia_ptr, DAT_CONN_QUAL serviceID, DAPL_SP * sp_ptr)
 	if ((bind(cm_ptr->socket, (struct sockaddr *)&addr, sizeof(addr)) < 0)
 	    || (listen(cm_ptr->socket, 128) < 0)) {
 		int err = dapl_socket_errno();
-		dapl_log(DAPL_DBG_TYPE_CM,
-			 " listen: ERROR 0x%x %s on port %d\n",
-			 err, strerror(err), serviceID + 1000);
 		if (err == EADDRINUSE)
 			dat_status = DAT_CONN_QUAL_IN_USE;
-		else
-			dat_status = DAT_CONN_QUAL_UNAVAILABLE;
+		else {
+			dapl_log(DAPL_DBG_TYPE_WARN,
+				 " listen: ERROR 0x%x %s on port %d\n",
+				 err, strerror(err), serviceID + 1000);
+			dat_status = DAT_INVALID_PARAMETER;
+		}
 		goto bail;
 	}