From: Johan Hovold Date: Tue, 29 Jul 2014 12:14:55 +0000 (+0200) Subject: USB: option: reduce interrupt-urb logging verbosity X-Git-Tag: v3.17-rc3~11^2~17^2~7 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=f0e4cba2534cd88476dff920727c81350130f3c5;p=~emulex%2Finfiniband.git USB: option: reduce interrupt-urb logging verbosity Do not log normal interrupt-urb shutdowns as errors. The option driver has always been logging any nonzero interrupt-urb status as an error, including when the urb is killed during normal operation. Commit 9096f1fbba91 ("USB: usb_wwan: fix potential NULL-deref at resume") moved the interrupt urb submission from port probe and release to open and close, thus potentially increasing the number of these false-positive error messages dramatically. Reported-by: Ed Butler Tested-by: Ed Butler Cc: Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a9688940543..34f142be5b8 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1916,6 +1916,8 @@ static void option_instat_callback(struct urb *urb) dev_dbg(dev, "%s: type %x req %x\n", __func__, req_pkt->bRequestType, req_pkt->bRequest); } + } else if (status == -ENOENT || status == -ESHUTDOWN) { + dev_dbg(dev, "%s: urb stopped: %d\n", __func__, status); } else dev_err(dev, "%s: error %d\n", __func__, status);