From: Florian Tobias Schandinat Date: Wed, 22 Sep 2010 02:33:52 +0000 (+0000) Subject: viafb: use proper register for colour when doing fill ops X-Git-Tag: v2.6.37-rc1~80^2~5 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=efd4f6398dc92b5bf392670df862f42a19f34cf2;p=~shefty%2Frdma-dev.git viafb: use proper register for colour when doing fill ops The colour was written to a wrong register for fillrect operations. This sometimes caused empty console space (for example after 'clear') to have a different colour than desired. Fix this by writing to the correct register. Many thanks to Daniel Drake and Jon Nettleton for pointing out this issue and pointing me in the right direction for the fix. Fixes http://dev.laptop.org/ticket/9323 Signed-off-by: Florian Tobias Schandinat Cc: Joseph Chan Cc: Daniel Drake Cc: Jon Nettleton Cc: stable@kernel.org --- diff --git a/drivers/video/via/accel.c b/drivers/video/via/accel.c index e44893ea590..c2f4e6e166f 100644 --- a/drivers/video/via/accel.c +++ b/drivers/video/via/accel.c @@ -283,11 +283,12 @@ static int hw_bitblt_2(void __iomem *engine, u8 op, u32 width, u32 height, writel(tmp, engine + 0x1C); } - if (op != VIA_BITBLT_COLOR) + if (op == VIA_BITBLT_FILL) { + writel(fg_color, engine + 0x58); + } else if (op == VIA_BITBLT_MONO) { writel(fg_color, engine + 0x4C); - - if (op == VIA_BITBLT_MONO) writel(bg_color, engine + 0x50); + } if (op == VIA_BITBLT_FILL) ge_cmd |= fill_rop << 24 | 0x00002000 | 0x00000001;