From: roel kluin <roel.kluin@gmail.com>
Date: Mon, 21 Sep 2009 10:08:48 +0000 (+0000)
Subject: bcm63xx_enet: timeout off by one in do_mdio_op()
X-Git-Tag: v2.6.32-rc3~12^2~31
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=ec1652af18ef02c7c6ceeabb64f56f16eaf40ae9;p=~shefty%2Frdma-dev.git

bcm63xx_enet: timeout off by one in do_mdio_op()

`while (limit-- >= 0)' reaches -2 after the loop upon timeout.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/bcm63xx_enet.c b/drivers/net/bcm63xx_enet.c
index 09d270913c5..ba29dc319b3 100644
--- a/drivers/net/bcm63xx_enet.c
+++ b/drivers/net/bcm63xx_enet.c
@@ -90,7 +90,7 @@ static int do_mdio_op(struct bcm_enet_priv *priv, unsigned int data)
 		if (enet_readl(priv, ENET_IR_REG) & ENET_IR_MII)
 			break;
 		udelay(1);
-	} while (limit-- >= 0);
+	} while (limit-- > 0);
 
 	return (limit < 0) ? 1 : 0;
 }