From: Vinod Koul <vinod.koul@linux.intel.com>
Date: Fri, 11 May 2012 05:54:41 +0000 (+0530)
Subject: dmaengine: pl330: dont complete descriptor for cyclic dma
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=eab21585580344c8533d5e7bc4edea27ad1e268f;p=~shefty%2Frdma-dev.git

dmaengine: pl330: dont complete descriptor for cyclic dma

the cookie updates completed the cyclic dma descriptor wrongly. This caused the
BUG_ON to be hit as submit is called for completed descriptor

Fix this by not marking the cyclic descriptor as complete

Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Tested-by: Thomas Abraham <thomas.abraham@linaro.org>
---

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 2ee6e23930a..fa3fb21e60b 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2322,7 +2322,8 @@ static void pl330_tasklet(unsigned long data)
 	/* Pick up ripe tomatoes */
 	list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
 		if (desc->status == DONE) {
-			dma_cookie_complete(&desc->txd);
+			if (pch->cyclic)
+				dma_cookie_complete(&desc->txd);
 			list_move_tail(&desc->node, &list);
 		}