From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 9 Apr 2012 20:52:34 +0000 (+0200)
Subject: ipw2100: remove a redundant NULL check before calling release_firmware()
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=e3e07e0b10b3e6ca5cc7f6f4bf28d3419a9a12e4;p=~shefty%2Frdma-dev.git

ipw2100: remove a redundant NULL check before calling release_firmware()

The release_firmware() function does its own NULL test so a test
before calling it is rather redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c
index f0551f807f6..d8d804e3a4b 100644
--- a/drivers/net/wireless/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/ipw2x00/ipw2100.c
@@ -8508,8 +8508,7 @@ static void ipw2100_release_firmware(struct ipw2100_priv *priv,
 				     struct ipw2100_fw *fw)
 {
 	fw->version = 0;
-	if (fw->fw_entry)
-		release_firmware(fw->fw_entry);
+	release_firmware(fw->fw_entry);
 	fw->fw_entry = NULL;
 }