From: Luca Barbieri <luca@luca-barbieri.com>
Date: Sat, 20 Feb 2010 10:08:56 +0000 (+0100)
Subject: drm/nouveau: fix missing spin_unlock in failure path
X-Git-Tag: v2.6.34-rc1~209^2~12^2~16
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=e32b2c883bfe9b57c660b5db31a62cea96c0c046;p=~shefty%2Frdma-dev.git

drm/nouveau: fix missing spin_unlock in failure path

Found by sparse.

Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
Signed-off-by: Francisco Jerez <currojerez@riseup.net>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
---

diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index fee959c72f4..8265fed528f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -558,11 +558,11 @@ nouveau_gem_pushbuf_reloc_apply(struct drm_device *dev,
 
 		spin_lock(&nvbo->bo.lock);
 		ret = ttm_bo_wait(&nvbo->bo, false, false, false);
+		spin_unlock(&nvbo->bo.lock);
 		if (ret) {
 			NV_ERROR(dev, "reloc wait_idle failed: %d\n", ret);
 			break;
 		}
-		spin_unlock(&nvbo->bo.lock);
 
 		nouveau_bo_wr32(nvbo, r->reloc_bo_offset >> 2, data);
 	}