From: roel kluin <roel.kluin@gmail.com>
Date: Sun, 27 Dec 2009 03:26:12 +0000 (+0000)
Subject: atarilance: timeout ignored in lance_open()
X-Git-Tag: v2.6.33-rc4~10^2~39
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=e145b98484f5c7444151e90cc0853f14e6d396a4;p=~emulex%2Finfiniband.git

atarilance: timeout ignored in lance_open()

With `while (--i > 0)' i reaches 0 after the loop, so upon timeout the
error was not issued.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/atarilance.c b/drivers/net/atarilance.c
index c5721cb3826..cc9ed864391 100644
--- a/drivers/net/atarilance.c
+++ b/drivers/net/atarilance.c
@@ -663,7 +663,7 @@ static int lance_open( struct net_device *dev )
 	while (--i > 0)
 		if (DREG & CSR0_IDON)
 			break;
-	if (i < 0 || (DREG & CSR0_ERR)) {
+	if (i <= 0 || (DREG & CSR0_ERR)) {
 		DPRINTK( 2, ( "lance_open(): opening %s failed, i=%d, csr0=%04x\n",
 					  dev->name, i, DREG ));
 		DREG = CSR0_STOP;