From: Bartlomiej Zolnierkiewicz Date: Thu, 3 Dec 2009 19:32:10 +0000 (+0100) Subject: pata_it8213: fix UDMA handling X-Git-Tag: v2.6.33-rc1~380^2~19 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=e0ee792b75a5cf1b23acfeae7ce3c386f805b20b;p=~emulex%2Finfiniband.git pata_it8213: fix UDMA handling Driver should program the cycle timing not the mode number (doing the latter results in wrong timings being used). There shouldn't be any problems with it as IDE it8213 host driver has been doing it this way for years. Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Jeff Garzik --- diff --git a/drivers/ata/pata_it8213.c b/drivers/ata/pata_it8213.c index f156da8076f..36d1f61491d 100644 --- a/drivers/ata/pata_it8213.c +++ b/drivers/ata/pata_it8213.c @@ -173,10 +173,10 @@ static void it8213_set_dmamode (struct ata_port *ap, struct ata_device *adev) udma_enable |= (1 << devid); - /* Load the UDMA mode number */ + /* Load the UDMA cycle time */ pci_read_config_word(dev, 0x4A, &udma_timing); udma_timing &= ~(3 << (4 * devid)); - udma_timing |= (udma & 3) << (4 * devid); + udma_timing |= u_speed << (4 * devid); pci_write_config_word(dev, 0x4A, udma_timing); /* Load the clock selection */