From: akpm@linux-foundation.org <akpm@linux-foundation.org>
Date: Tue, 30 Nov 2010 21:51:13 +0000 (-0800)
Subject: headers_check: better search for functions in headers
X-Git-Tag: v2.6.38-rc1~437^2~3
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=de323f22a83b024b7432e813609c6efb74b1bbfc;p=~shefty%2Frdma-dev.git

headers_check: better search for functions in headers

Some headers don't bother with "extern" in function prototypes, which
results in said prototypes being unnoticed and exported to userland.

This patch slightly improves detection of such cases by checking for C
type names as well in the beginning of a line.

Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: WANG Cong <amwang@redhat.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---

diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 50d6cfd1fa7..e0e25a1c2c1 100644
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -64,7 +64,7 @@ sub check_include
 
 sub check_declarations
 {
-	if ($line =~m/^\s*extern\b/) {
+	if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
 		printf STDERR "$filename:$lineno: " .
 		              "userspace cannot call function or variable " .
 		              "defined in the kernel\n";