From: Satyam Sharma <satyam@infradead.org>
Date: Fri, 10 Aug 2007 22:28:10 +0000 (-0700)
Subject: [NET] netconsole: Remove bogus check
X-Git-Tag: v2.6.24-rc1~1454^2~811
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=d133ccbdc30c7f86459519cec1126d6473762b10;p=~emulex%2Finfiniband.git

[NET] netconsole: Remove bogus check

Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.

The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
set by netpoll_setup(), which is called by init_netconsole() before
register_console(), so write_msg() cannot be triggered unless netpoll_setup()
successfully set np.dev.  Also np.dev cannot go away from under us, because
netpoll_setup() grabs us reference on it.  So let's remove the bogus check.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index f1c2a2defd7..2c2aef1ae8e 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
 	int frag, left;
 	unsigned long flags;
 
-	if (!np.dev)
-		return;
-
 	local_irq_save(flags);
 
 	for (left = len; left;) {