From: Hemmo Nieminen Date: Thu, 15 Jan 2015 21:01:59 +0000 (+0200) Subject: MIPS: Fix kernel lockup or crash after CPU offline/online X-Git-Tag: v3.19~11^2~8 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=c7754e75100ed5e3068ac5085747f2bfc386c8d6;p=~emulex%2Finfiniband.git MIPS: Fix kernel lockup or crash after CPU offline/online As printk() invocation can cause e.g. a TLB miss, printk() cannot be called before the exception handlers have been properly initialized. This can happen e.g. when netconsole has been loaded as a kernel module and the TLB table has been cleared when a CPU was offline. Call cpu_report() in start_secondary() only after the exception handlers have been initialized to fix this. Without the patch the kernel will randomly either lockup or crash after a CPU is onlined and the console driver is a module. Signed-off-by: Hemmo Nieminen Signed-off-by: Aaro Koskinen Cc: stable@vger.kernel.org Cc: David Daney Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/8953/ Signed-off-by: Ralf Baechle --- diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c index c94c4e92e17..1c0d8c50b7e 100644 --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -123,10 +123,10 @@ asmlinkage void start_secondary(void) unsigned int cpu; cpu_probe(); - cpu_report(); per_cpu_trap_init(false); mips_clockevent_init(); mp_ops->init_secondary(); + cpu_report(); /* * XXX parity protection should be folded in here when it's converted