From: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Date: Thu, 13 Jan 2011 23:28:39 +0000 (-0800)
Subject: [fs/9p] Plug potential acl leak
X-Git-Tag: v2.6.39-rc1~489^2~45
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=c61fa0d6d9d466356ffa89fa1c1a9a1cd726fab4;p=~shefty%2Frdma-dev.git

[fs/9p] Plug potential acl leak

In v9fs_get_acl() if __v9fs_get_acl() gets only one of the
dacl/pacl we are not releasing it.

Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---

diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index 02a2cf61631..291ff7be27f 100644
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -71,11 +71,15 @@ int v9fs_get_acl(struct inode *inode, struct p9_fid *fid)
 	if (!IS_ERR(dacl) && !IS_ERR(pacl)) {
 		set_cached_acl(inode, ACL_TYPE_DEFAULT, dacl);
 		set_cached_acl(inode, ACL_TYPE_ACCESS, pacl);
-		posix_acl_release(dacl);
-		posix_acl_release(pacl);
 	} else
 		retval = -EIO;
 
+	if (!IS_ERR(dacl))
+		posix_acl_release(dacl);
+
+	if (!IS_ERR(pacl))
+		posix_acl_release(pacl);
+
 	return retval;
 }