From: Stephen Boyd <sboyd@codeaurora.org>
Date: Thu, 12 May 2011 23:50:07 +0000 (-0700)
Subject: debugfs: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning
X-Git-Tag: v3.0-rc1~390^2
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=c42d2237143fcf35cff642cefe2bcf7786aae312;p=~emulex%2Finfiniband.git

debugfs: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning

Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
warning:

In file included from arch/x86/include/asm/uaccess.h:573,
                 from include/linux/uaccess.h:5,
                 from include/linux/highmem.h:7,
                 from include/linux/pagemap.h:10,
                 from fs/debugfs/file.c:18:
In function 'copy_from_user',
    inlined from 'write_file_bool' at fs/debugfs/file.c:435:
arch/x86/include/asm/uaccess_64.h:65: warning: call to
'copy_from_user_overflow' declared with attribute warning:
copy_from_user() buffer size is not provably correct

presumably due to buf_size being signed causing GCC to fail to
see that buf_size can't become negative.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 568304d058a..90f76575c05 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -428,7 +428,7 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf,
 			       size_t count, loff_t *ppos)
 {
 	char buf[32];
-	int buf_size;
+	size_t buf_size;
 	bool bv;
 	u32 *val = file->private_data;