From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 6 Nov 2009 05:03:39 +0000 (-0800)
Subject: net: sock_bindtodevice() RCU-ification
X-Git-Tag: v2.6.33-rc1~388^2~491
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=bf8e56bfc4fcfcef9f08e6233dc619706807893a;p=~shefty%2Frdma-dev.git

net: sock_bindtodevice() RCU-ification

Avoid dev_hold()/dev_put() in sock_bindtodevice()

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/sock.c b/net/core/sock.c
index 5a51512f638..38820eaecd4 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -420,14 +420,16 @@ static int sock_bindtodevice(struct sock *sk, char __user *optval, int optlen)
 	if (devname[0] == '\0') {
 		index = 0;
 	} else {
-		struct net_device *dev = dev_get_by_name(net, devname);
+		struct net_device *dev;
 
+		rcu_read_lock();
+		dev = dev_get_by_name_rcu(net, devname);
+		if (dev)
+			index = dev->ifindex;
+		rcu_read_unlock();
 		ret = -ENODEV;
 		if (!dev)
 			goto out;
-
-		index = dev->ifindex;
-		dev_put(dev);
 	}
 
 	lock_sock(sk);