From: Denis Efremov Date: Thu, 11 Oct 2012 02:08:02 +0000 (+1100) Subject: md/linear: rcu_dereference outside read-lock section X-Git-Tag: v3.7-rc1~10^2~28 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=bc78c57388e7f447f58e30d60b1505ddaaaf3a7d;p=~emulex%2Finfiniband.git md/linear: rcu_dereference outside read-lock section According to the comment in linear_stop function rcu_dereference in linear_start and linear_stop functions occurs under reconfig_mutex. The patch represents this agreement in code and prevents lockdep complaint. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Denis Efremov Signed-off-by: NeilBrown --- diff --git a/drivers/md/linear.c b/drivers/md/linear.c index fa211d80fc0..92c64d162a9 100644 --- a/drivers/md/linear.c +++ b/drivers/md/linear.c @@ -244,7 +244,9 @@ static int linear_add(struct mddev *mddev, struct md_rdev *rdev) if (!newconf) return -ENOMEM; - oldconf = rcu_dereference(mddev->private); + oldconf = rcu_dereference_protected(mddev->private, + lockdep_is_held( + &mddev->reconfig_mutex)); mddev->raid_disks++; rcu_assign_pointer(mddev->private, newconf); md_set_array_sectors(mddev, linear_size(mddev, 0, 0)); @@ -256,7 +258,10 @@ static int linear_add(struct mddev *mddev, struct md_rdev *rdev) static int linear_stop (struct mddev *mddev) { - struct linear_conf *conf = mddev->private; + struct linear_conf *conf = + rcu_dereference_protected(mddev->private, + lockdep_is_held( + &mddev->reconfig_mutex)); /* * We do not require rcu protection here since