From: Maurizio Lombardi Date: Tue, 27 May 2014 16:48:56 +0000 (-0400) Subject: ext4: fix wrong assert in ext4_mb_normalize_request() X-Git-Tag: v3.16-rc1~79^2~1 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=b5b60778558cafad17bbcbf63e0310bd3c68eb17;p=~emulex%2Finfiniband.git ext4: fix wrong assert in ext4_mb_normalize_request() The variable "size" is expressed as number of blocks and not as number of clusters, this could trigger a kernel panic when using ext4 with the size of a cluster different from the size of a block. Cc: stable@vger.kernel.org Signed-off-by: Maurizio Lombardi Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 6ca41e7a3fe..11dc4e0033c 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3145,7 +3145,7 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, } BUG_ON(start + size <= ac->ac_o_ex.fe_logical && start > ac->ac_o_ex.fe_logical); - BUG_ON(size <= 0 || size > EXT4_CLUSTERS_PER_GROUP(ac->ac_sb)); + BUG_ON(size <= 0 || size > EXT4_BLOCKS_PER_GROUP(ac->ac_sb)); /* now prepare goal request */