From: Li Zefan <lizefan@huawei.com>
Date: Wed, 30 Jul 2014 07:07:13 +0000 (+0800)
Subject: cpuset: fix the WARN_ON() in update_nodemasks_hier()
X-Git-Tag: v3.17-rc1~147^2
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=a13812683f1118ee4deed88d8d9bc2c268358b2e;p=~emulex%2Finfiniband.git

cpuset: fix the WARN_ON() in update_nodemasks_hier()

The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.

Reported-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Tested-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index f337f42a07a..9d7264beb74 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1136,7 +1136,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
 		mutex_unlock(&callback_mutex);
 
 		WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
-			nodes_equal(cp->mems_allowed, cp->effective_mems));
+			!nodes_equal(cp->mems_allowed, cp->effective_mems));
 
 		update_tasks_nodemask(cp);