From: Fabio Estevam Date: Wed, 26 Feb 2014 23:53:40 +0000 (-0300) Subject: imx-drm: imx-ldb: Check 'mode' pointer first X-Git-Tag: v3.15-rc1~139^2~822 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=9f9b036f0e5ee1ea4f0487a793542ca7ba06de35;p=~emulex%2Finfiniband.git imx-drm: imx-ldb: Check 'mode' pointer first Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter Signed-off-by: Fabio Estevam Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index 5168c76cff5..abf85170f6d 100644 --- a/drivers/staging/imx-drm/imx-ldb.c +++ b/drivers/staging/imx-drm/imx-ldb.c @@ -106,6 +106,8 @@ static int imx_ldb_connector_get_modes(struct drm_connector *connector) struct drm_display_mode *mode; mode = drm_mode_create(connector->dev); + if (!mode) + return -EINVAL; drm_mode_copy(mode, &imx_ldb_ch->mode); mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; drm_mode_probed_add(connector, mode);