From: Alexander Duyck Date: Mon, 27 Aug 2012 06:30:01 +0000 (+0000) Subject: ipv4: Minor logic clean-up in ipv4_mtu X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=98d75c3724f9b37cdfdb85f821e10edcb743959e;p=~shefty%2Frdma-dev.git ipv4: Minor logic clean-up in ipv4_mtu In ipv4_mtu there is some logic where we are testing for a non-zero value and a timer expiration, then setting the value to zero, and then testing if the value is zero we set it to a value based on the dst. Instead of bothering with the extra steps it is easier to just cleanup the logic so that we set it to the dst based value if it is zero or if the timer has expired. Signed-off-by: Alexander Duyck --- diff --git a/net/ipv4/route.c b/net/ipv4/route.c index d2d1e153e7c..dc9549b5eb1 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1134,10 +1134,7 @@ static unsigned int ipv4_mtu(const struct dst_entry *dst) const struct rtable *rt = (const struct rtable *) dst; unsigned int mtu = rt->rt_pmtu; - if (mtu && time_after_eq(jiffies, rt->dst.expires)) - mtu = 0; - - if (!mtu) + if (!mtu || time_after_eq(jiffies, rt->dst.expires)) mtu = dst_metric_raw(dst, RTAX_MTU); if (mtu && rt_is_output_route(rt))