From: Sven Eckelmann Date: Sat, 18 Sep 2010 19:01:17 +0000 (+0200) Subject: Staging: batman-adv: Remove unneeded rcu_read_lock X-Git-Tag: v2.6.37-rc1~60^2~3^2~548 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=952c699c06f562b07dba4b1f91dfc02de928545d;p=~emulex%2Finfiniband.git Staging: batman-adv: Remove unneeded rcu_read_lock Regions which do not use rcu functions don't need to protected by rcu_read_lock. If we want to protect data from being freed than it must be covered by the same read-side critical section or otherwise the grace period may already ended and freed the memory before we called rcu_read_lock again. Signed-off-by: Sven Eckelmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/batman-adv/originator.c b/drivers/staging/batman-adv/originator.c index f25d7fdfe81..c530df12e03 100644 --- a/drivers/staging/batman-adv/originator.c +++ b/drivers/staging/batman-adv/originator.c @@ -329,7 +329,6 @@ int orig_seq_print_text(struct seq_file *seq, void *offset) net_dev->name); } - rcu_read_lock(); seq_printf(seq, "[B.A.T.M.A.N. adv %s%s, MainIF/MAC: %s/%s (%s)]\n", SOURCE_VERSION, REVISION_VERSION_STR, bat_priv->primary_if->net_dev->name, @@ -337,7 +336,6 @@ int orig_seq_print_text(struct seq_file *seq, void *offset) seq_printf(seq, " %-15s %s (%s/%i) %17s [%10s]: %20s ...\n", "Originator", "last-seen", "#", TQ_MAX_VALUE, "Nexthop", "outgoingIF", "Potential nexthops"); - rcu_read_unlock(); spin_lock_irqsave(&bat_priv->orig_hash_lock, flags);