From: Jesse Gross Date: Sun, 9 Jan 2011 06:23:30 +0000 (+0000) Subject: net offloading: Accept NETIF_F_HW_CSUM for all protocols. X-Git-Tag: v2.6.38-rc1~403^2~43 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=9497a0518e8183959e45da05f317f1cb36f2cd7c;p=~emulex%2Finfiniband.git net offloading: Accept NETIF_F_HW_CSUM for all protocols. We currently only have software fallback for one type of checksum: the TCP/UDP one's complement. This means that a protocol that uses hardware offloading for a different type of checksum (FCoE, SCTP) must directly check the device's features and do the right thing ahead of time. By the time we get to dev_can_checksum(), we're only deciding whether to apply the one algorithm in software or hardware. NETIF_F_HW_CSUM has the same capabilities as the software version, so we should always use it if present. The primary advantage of this is multiply tagged vlans can use hardware checksumming. Signed-off-by: Jesse Gross Signed-off-by: David S. Miller --- diff --git a/net/core/dev.c b/net/core/dev.c index a215269d2e3..d8befd06da0 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1734,7 +1734,7 @@ EXPORT_SYMBOL(netif_device_attach); static bool can_checksum_protocol(unsigned long features, __be16 protocol) { - return ((features & NETIF_F_NO_CSUM) || + return ((features & NETIF_F_GEN_CSUM) || ((features & NETIF_F_V4_CSUM) && protocol == htons(ETH_P_IP)) || ((features & NETIF_F_V6_CSUM) &&