From: Markus Elfring Date: Thu, 20 Nov 2014 10:13:16 +0000 (-0300) Subject: [media] i2c: Deletion of an unnecessary check before the function call "rc_unregister... X-Git-Tag: v3.19-rc1~126^2~68 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=8f1aeedf78f5528a4471b019a39952aeb52dfa5b;p=~emulex%2Finfiniband.git [media] i2c: Deletion of an unnecessary check before the function call "rc_unregister_device" The rc_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c index 8311f1a9a38..175a7611495 100644 --- a/drivers/media/i2c/ir-kbd-i2c.c +++ b/drivers/media/i2c/ir-kbd-i2c.c @@ -464,8 +464,7 @@ static int ir_remove(struct i2c_client *client) cancel_delayed_work_sync(&ir->work); /* unregister device */ - if (ir->rc) - rc_unregister_device(ir->rc); + rc_unregister_device(ir->rc); /* free memory */ return 0;