From: Evgeniy Dushistov Date: Mon, 29 Jan 2007 21:19:55 +0000 (-0800) Subject: [PATCH] ufs: truncate negative to unsigned fix X-Git-Tag: v2.6.20-rc7~35 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=8682164a66325cab07620082eb7f413b547f4b4a;p=~shefty%2Frdma-dev.git [PATCH] ufs: truncate negative to unsigned fix During ufs_trunc_direct which is subroutine of ufs::truncate, we try the first of all free parts of block and then whole blocks. But we calculate size of block's part to free in the wrong way. This may cause bad update of used blocks and fragments statistic, and you can got report that you have free 32T on 1Gb partition. Signed-off-by: Evgeniy Dushistov Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c index ea11d04c41a..0437b0a6fe9 100644 --- a/fs/ufs/truncate.c +++ b/fs/ufs/truncate.c @@ -109,10 +109,10 @@ static int ufs_trunc_direct (struct inode * inode) tmp = fs32_to_cpu(sb, *p); if (!tmp ) ufs_panic (sb, "ufs_trunc_direct", "internal error"); + frag2 -= frag1; frag1 = ufs_fragnum (frag1); - frag2 = ufs_fragnum (frag2); - ufs_free_fragments (inode, tmp + frag1, frag2 - frag1); + ufs_free_fragments(inode, tmp + frag1, frag2); mark_inode_dirty(inode); frag_to_free = tmp + frag1;