From: David S. Miller Date: Tue, 17 Jan 2006 10:54:21 +0000 (-0800) Subject: [NET]: Make second arg to skb_reserved() signed. X-Git-Tag: v2.6.16-rc2~367^2~7 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=8243126c5e29030bf1a3fb75187a513966dcba62;p=~emulex%2Finfiniband.git [NET]: Make second arg to skb_reserved() signed. Some subsystems, such as PPP, can send negative values here. It just happened to work correctly on 32-bit with an unsigned value, but on 64-bit this explodes. Figured out by Paul Mackerras based upon several PPP crash reports. Signed-off-by: David S. Miller --- diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index e5fd66c5650..ad7cc22bd42 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -926,7 +926,7 @@ static inline int skb_tailroom(const struct sk_buff *skb) * Increase the headroom of an empty &sk_buff by reducing the tail * room. This is only allowed for an empty buffer. */ -static inline void skb_reserve(struct sk_buff *skb, unsigned int len) +static inline void skb_reserve(struct sk_buff *skb, int len) { skb->data += len; skb->tail += len;