From: David Brownell <david-b@pacbell.net>
Date: Thu, 15 Nov 2007 01:00:04 +0000 (-0800)
Subject: tle62x0 driver stops ignoring read errors
X-Git-Tag: v2.6.24-rc3~73
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=822bd5aa2b8e8fa1d328f03bf5b9c75701481bf0;p=~shefty%2Frdma-dev.git

tle62x0 driver stops ignoring read errors

The tle62x0 driver was ignoring all read errors.  This patch makes it
pass such errors up the stack, instead of returning bogus data.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/spi/tle62x0.c b/drivers/spi/tle62x0.c
index 6da58ca48b3..455991fbe28 100644
--- a/drivers/spi/tle62x0.c
+++ b/drivers/spi/tle62x0.c
@@ -107,8 +107,11 @@ static ssize_t tle62x0_status_show(struct device *dev,
 
 	mutex_lock(&st->lock);
 	ret = tle62x0_read(st);
-
 	dev_dbg(dev, "tle62x0_read() returned %d\n", ret);
+	if (ret < 0) {
+		mutex_unlock(&st->lock);
+		return ret;
+	}
 
 	for (ptr = 0; ptr < (st->nr_gpio * 2)/8; ptr += 1) {
 		fault <<= 8;