From: Peter Huewe Date: Tue, 19 Feb 2013 04:13:50 +0000 (+0100) Subject: staging/slicoss: Check pointer before dereferencing X-Git-Tag: v3.10-rc1~192^2~776 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=81372118c6fc12d41b6e978b915cc010fe6e5700;p=~emulex%2Finfiniband.git staging/slicoss: Check pointer before dereferencing Smatch complains that the variable adapter is dereferenced before it is checked: slicoss.c:906 slic_timer_load_check() warn: variable dereferenced before check 'adapter' (see line 904) -> move the assignment after the check. Signed-off-by: Peter Huewe Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 76fc2e554f3..753993c867f 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -901,10 +901,9 @@ static void slic_timer_load_check(ulong cardaddr) u32 load = card->events; u32 level = 0; - intagg = &adapter->slic_regs->slic_intagg; - if ((adapter) && (adapter->state == ADAPT_UP) && (card->state == CARD_UP) && (slic_global.dynamic_intagg)) { + intagg = &adapter->slic_regs->slic_intagg; if (adapter->devid == SLIC_1GB_DEVICE_ID) { if (adapter->linkspeed == LINK_1000MB) level = 100;