From: Güngör Erseymen Date: Fri, 7 Jun 2013 18:29:50 +0000 (+0300) Subject: staging: comedi: remove 'bi.subdevice < 0' check in do_bufinfo_ioctl() X-Git-Tag: v3.11-rc1~158^2~185 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=7b1a5e2f4f5afde4f1dadf58223c2f293208293b;p=~emulex%2Finfiniband.git staging: comedi: remove 'bi.subdevice < 0' check in do_bufinfo_ioctl() Type of variable 'bi' is struct comedi_bufinfo and 'subdevice' is defined as unsigned, so there is no need to check if it is less then zero. Signed-off-by: Güngör Erseymen Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 986f1957268..c561a0eda92 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -913,7 +913,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev, if (copy_from_user(&bi, arg, sizeof(bi))) return -EFAULT; - if (bi.subdevice >= dev->n_subdevices || bi.subdevice < 0) + if (bi.subdevice >= dev->n_subdevices) return -EINVAL; s = &dev->subdevices[bi.subdevice];