From: Greg Kroah-Hartman Date: Tue, 27 Aug 2013 22:59:53 +0000 (-0700) Subject: Revert "serial: omap: Fix IRQ handling return value" X-Git-Tag: v3.12-rc1~182^2~46 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=7b013e440a4ebe05d32ad4ecd657c276f3994558;p=~emulex%2Finfiniband.git Revert "serial: omap: Fix IRQ handling return value" This reverts commit 908fd7e566b4c12e36e4487d2d5946de5e5ea30f. Kevin writes: Greg, without a better justification in the changelog, I think this patch should be dropped from tty-next. Reported-by: Kevin Hilman Cc: Ruchika Kharwar Cc: Alexander Savchenko Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 2fa7b5ce2e0..b0f46e666e1 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -538,6 +538,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id) struct uart_omap_port *up = dev_id; unsigned int iir, lsr; unsigned int type; + irqreturn_t ret = IRQ_NONE; int max_count = 256; spin_lock(&up->port.lock); @@ -548,6 +549,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id) if (iir & UART_IIR_NO_INT) break; + ret = IRQ_HANDLED; lsr = serial_in(up, UART_LSR); /* extract IRQ type from IIR register */ @@ -586,7 +588,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id) pm_runtime_put_autosuspend(up->dev); up->port_activity = jiffies; - return IRQ_HANDLED; + return ret; } static unsigned int serial_omap_tx_empty(struct uart_port *port)