From: NeilBrown Date: Mon, 5 Mar 2012 06:48:12 +0000 (+1100) Subject: md/raid10: fix assembling of arrays with replacement devices. X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=7a90484825680e7831856105f5fef654e6c02701;p=~shefty%2Frdma-dev.git md/raid10: fix assembling of arrays with replacement devices. commit 56a2559bb654a (md/raid10: recognise replacements ...) changed 'run' to set ->replacement or ->rdev depending on the 'Replacement' status if the device, but it didn't remove the old unconditional setting of 'rdev'. So it was largely ineffective. So remove that now. Signed-off-by: NeilBrown --- diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index bd06ea21756..58c44d6453a 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -3260,7 +3260,6 @@ static int run(struct mddev *mddev) disk->rdev = rdev; } - disk->rdev = rdev; disk_stack_limits(mddev->gendisk, rdev->bdev, rdev->data_offset << 9); /* as we don't honour merge_bvec_fn, we must never risk