From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 17 Dec 2013 07:29:17 +0000 (+0800)
Subject: sch_cbq: remove unnecessary null pointer check
X-Git-Tag: v3.14-rc1~94^2~432
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=79c11f2e3fd3e0e3594d4155821ef426153a773f;p=~emulex%2Finfiniband.git

sch_cbq: remove unnecessary null pointer check

It already has a NULL pointer check of rtab in qdisc_put_rtab().
Remove the check outside of qdisc_put_rtab().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c
index d5a8a4b2454..e2518333380 100644
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -1783,8 +1783,7 @@ cbq_change_class(struct Qdisc *sch, u32 classid, u32 parentid, struct nlattr **t
 						    qdisc_root_sleeping_lock(sch),
 						    tca[TCA_RATE]);
 			if (err) {
-				if (rtab)
-					qdisc_put_rtab(rtab);
+				qdisc_put_rtab(rtab);
 				return err;
 			}
 		}