From: Anthony Liguori Date: Mon, 7 Apr 2008 20:33:16 +0000 (-0500) Subject: virtio_net: remove overzealous printk X-Git-Tag: v2.6.25-rc9~49 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=6ea0a4679d6a11c66cfeb26d15244fb6f9b52d14;p=~shefty%2Frdma-dev.git virtio_net: remove overzealous printk The 'disable_cb' is really just a hint and as such, it's possible for more work to get queued up while callbacks are disabled. Under stress with an SMP guest, this printk triggers very frequently. There is no race here, this is how things are designed to work so let's just remove the printk. Signed-off-by: Anthony Liguori Acked-by: Rusty Russell Signed-off-by: Linus Torvalds --- diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b58472cf76f..d1a200ff5fd 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -284,7 +284,6 @@ again: /* Activate callback for using skbs: if this returns false it * means some were used in the meantime. */ if (unlikely(!vi->svq->vq_ops->enable_cb(vi->svq))) { - printk("Unlikely: restart svq race\n"); vi->svq->vq_ops->disable_cb(vi->svq); netif_start_queue(dev); goto again;