From: Devin Heitmueller Date: Mon, 12 Jul 2010 18:34:57 +0000 (-0300) Subject: [media] cx231xx: do not call video_mux as part of isoc setup X-Git-Tag: v2.6.37-rc1~64^2~282 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=6e6a2ba9cf67b437c51baacd20d58112ad74d685;p=~shefty%2Frdma-dev.git [media] cx231xx: do not call video_mux as part of isoc setup You cannot call the video_mux routine from within the isoc setup, because that code is shared with the digital isoc handler. This was causing the GPIOs and power control to be put into the wrong state when starting up digital mode. Signed-off-by: Devin Heitmueller Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/cx231xx/cx231xx-core.c b/drivers/media/video/cx231xx/cx231xx-core.c index 7beb201141c..4fc62c4f738 100644 --- a/drivers/media/video/cx231xx/cx231xx-core.c +++ b/drivers/media/video/cx231xx/cx231xx-core.c @@ -1002,12 +1002,6 @@ int cx231xx_init_isoc(struct cx231xx *dev, int max_packets, int j, k; int rc; - dev->video_input = dev->video_input > 2 ? 2 : dev->video_input; - - cx231xx_coredbg("Setting Video mux to %d\n", dev->video_input); - - video_mux(dev, dev->video_input); - /* De-allocates all pending stuff */ cx231xx_uninit_isoc(dev); diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c index 03a94e6a30e..06f492e7891 100644 --- a/drivers/media/video/cx231xx/cx231xx-video.c +++ b/drivers/media/video/cx231xx/cx231xx-video.c @@ -2667,7 +2667,9 @@ int cx231xx_register_analog_devices(struct cx231xx *dev) /* Analog specific initialization */ dev->format = &format[0]; - /* video_mux(dev, dev->video_input); */ + + /* Set the initial input */ + video_mux(dev, dev->video_input); /* Audio defaults */ dev->mute = 1;