From: Michael S. Tsirkin <mst@mellanox.co.il>
Date: Thu, 15 Dec 2005 21:55:50 +0000 (-0800)
Subject: IB/mthca: Fix thinko in mthca_table_find()
X-Git-Tag: v2.6.16-rc1~678^2~17
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=6c7d2a75b512c64c910b69adf32dbaddb461910b;p=~emulex%2Finfiniband.git

IB/mthca: Fix thinko in mthca_table_find()

break only escapes from the innermost loop, and we want to escape both
loops and return an answer.  Noticed by Ishai Rabinovitch.

Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---

diff --git a/drivers/infiniband/hw/mthca/mthca_memfree.c b/drivers/infiniband/hw/mthca/mthca_memfree.c
index 5798ed00d83..9fb985a016e 100644
--- a/drivers/infiniband/hw/mthca/mthca_memfree.c
+++ b/drivers/infiniband/hw/mthca/mthca_memfree.c
@@ -233,7 +233,7 @@ void *mthca_table_find(struct mthca_icm_table *table, int obj)
 		for (i = 0; i < chunk->npages; ++i) {
 			if (chunk->mem[i].length >= offset) {
 				page = chunk->mem[i].page;
-				break;
+				goto out;
 			}
 			offset -= chunk->mem[i].length;
 		}