From: yan <clouds.yan@gmail.com>
Date: Fri, 20 Apr 2012 13:25:53 +0000 (+0800)
Subject: lib/kobject.c : Remove redundant check in create_dir
X-Git-Tag: v3.5-rc1~147^2~70
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=6b9606106ba58d2bd80610f97e06fea58206b47c;p=~emulex%2Finfiniband.git

lib/kobject.c : Remove redundant check in create_dir

create_dir is a static function used only in kobject_add_internal.
There's no need to do check here, for kobject_add_internal will
reject kobject with invalid name.

Signed-off-by: Yan Hong <clouds.yan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/lib/kobject.c b/lib/kobject.c
index 21dee7c19af..bbffa2110d4 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -47,13 +47,11 @@ static int populate_dir(struct kobject *kobj)
 static int create_dir(struct kobject *kobj)
 {
 	int error = 0;
-	if (kobject_name(kobj)) {
-		error = sysfs_create_dir(kobj);
-		if (!error) {
-			error = populate_dir(kobj);
-			if (error)
-				sysfs_remove_dir(kobj);
-		}
+	error = sysfs_create_dir(kobj);
+	if (!error) {
+		error = populate_dir(kobj);
+		if (error)
+			sysfs_remove_dir(kobj);
 	}
 	return error;
 }