From: Kaike Wan <kaike.wan@intel.com>
Date: Tue, 15 Apr 2014 23:27:10 +0000 (-0700)
Subject: ibacm: Eliminate compiling warning "ignoring return value"
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=69c20f09753ff2fdb90ea1f382ae368a64700e58;p=~shefty%2Fibacm.git

ibacm: Eliminate compiling warning "ignoring return value"

Those warnings are produced when building rpm with
"rpmbuild -ta ibacm-1.0.8.tar.gz" after creating the
tar file with "make dist".

Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
---

diff --git a/src/acm.c b/src/acm.c
index 11f89c7..267a588 100644
--- a/src/acm.c
+++ b/src/acm.c
@@ -4164,7 +4164,11 @@ static int acm_open_lock_file(void)
 	}
 
 	snprintf(pid, sizeof pid, "%d\n", getpid());
-	write(lock_fd, pid, strlen(pid));
+	if (write(lock_fd, pid, strlen(pid)) != strlen(pid)){
+		lockf(lock_fd, F_ULOCK, 0);
+		close(lock_fd);
+		return -1;
+	}
 	return 0;
 }
 
@@ -4183,9 +4187,12 @@ static void daemonize(void)
 	if (chdir("/"))
 		exit(1);
 
-	freopen("/dev/null", "r", stdin);
-	freopen("/dev/null", "w", stdout);
-	freopen("/dev/null", "w", stderr);
+	if(!freopen("/dev/null", "r", stdin))
+		exit(1);
+	if(!freopen("/dev/null", "w", stdout))
+		exit(1);
+	if(!freopen("/dev/null", "w", stderr))
+		exit(1);
 }
 
 static void show_usage(char *program)
diff --git a/src/libacm.c b/src/libacm.c
index 4e42233..6ed653c 100644
--- a/src/libacm.c
+++ b/src/libacm.c
@@ -49,7 +49,8 @@ static void acm_set_server_port(void)
 	FILE *f;
 
 	if ((f = fopen("/var/run/ibacm.port", "r"))) {
-		fscanf(f, "%hu", (unsigned short *) &server_port);
+		if (fscanf(f, "%hu", (unsigned short *) &server_port) != 1) 
+			printf("Failed to read server port\n"); 
 		fclose(f);
 	}
 }