From: Sage Weil Date: Thu, 3 Mar 2011 20:14:53 +0000 (-0800) Subject: libceph: retry after authorization failure X-Git-Tag: v2.6.38-rc8~9^2~4 X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=692d20f576fb26f62c83f80dbf3ea899998391b7;p=~shefty%2Frdma-dev.git libceph: retry after authorization failure If we mark the connection CLOSED we will give up trying to reconnect to this server instance. That is appropriate for things like a protocol version mismatch that won't change until the server is restarted, at which point we'll get a new addr and reconnect. An authorization failure like this is probably due to the server not properly rotating it's secret keys, however, and should be treated as transient so that the normal backoff and retry behavior kicks in. Signed-off-by: Sage Weil --- diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index 35b36b86d76..6bd5025f622 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c @@ -1248,8 +1248,6 @@ static int process_connect(struct ceph_connection *con) con->auth_retry); if (con->auth_retry == 2) { con->error_msg = "connect authorization failure"; - reset_connection(con); - set_bit(CLOSED, &con->state); return -1; } con->auth_retry = 1;