From: Dan Carpenter <error27@gmail.com>
Date: Sat, 7 Aug 2010 22:17:51 +0000 (+0200)
Subject: tomoyo: cleanup. don't store bogus pointer
X-Git-Tag: v2.6.37-rc1~218^2~25
X-Git-Url: https://openfabrics.org/gitweb/?a=commitdiff_plain;h=68eda8f59081c74a51d037cc29893bd7c9b3c2d8;p=~shefty%2Frdma-dev.git

tomoyo: cleanup. don't store bogus pointer

If domain is NULL then &domain->list is a bogus address.  Let's leave
head->r.domain NULL instead of saving an unusable pointer.

This is just a cleanup.  The current code always checks head->r.eof
before dereferencing head->r.domain.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---

diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
index c668b447c72..e0a1059aaf3 100644
--- a/security/tomoyo/common.c
+++ b/security/tomoyo/common.c
@@ -768,8 +768,10 @@ static bool tomoyo_select_one(struct tomoyo_io_buffer *head, const char *data)
 		return true; /* Do nothing if open(O_WRONLY). */
 	memset(&head->r, 0, sizeof(head->r));
 	head->r.print_this_domain_only = true;
-	head->r.eof = !domain;
-	head->r.domain = &domain->list;
+	if (domain)
+		head->r.domain = &domain->list;
+	else
+		head->r.eof = 1;
 	tomoyo_io_printf(head, "# select %s\n", data);
 	if (domain && domain->is_deleted)
 		tomoyo_io_printf(head, "# This is a deleted domain.\n");